Everywhere: Remove needless trailing semi-colons after functions

This is a new option in clang-format-16.

Kernel/Arch/aarch64/RPi/Timer.cpp

@@ -67,7 +67,7 @@ bool Timer::handle_irq(RegisterState const& regs)
     clear_interrupt(TimerID::Timer1);
 
     return result;
-};
+}
 
 u64 Timer::update_time(u64& seconds_since_boot, u32& ticks_this_second, bool query_only)
 {

Kernel/Arch/x86_64/Interrupts/IOAPIC.h

@@ -51,7 +51,7 @@ public:
     virtual u16 get_irr() const override;
     virtual u32 gsi_base() const override { return m_gsi_base; }
     virtual size_t interrupt_vectors_count() const override { return m_redirection_entries_count; }
-    virtual StringView model() const override { return "IOAPIC"sv; };
+    virtual StringView model() const override { return "IOAPIC"sv; }
     virtual IRQControllerType type() const override { return IRQControllerType::i82093AA; }
 
 private:

Kernel/Arch/x86_64/Processor.cpp

@@ -1538,7 +1538,7 @@ NAKED void thread_context_first_enter(void)
         "    cld \n"
         "    call context_first_init \n"
         "    jmp common_trap_exit \n");
-};
+}
 
 NAKED void do_assume_context(Thread*, u32)
 {

Kernel/Bus/PCI/Definitions.h

@@ -374,7 +374,7 @@ public:
     u32 get_msix_table_offset() const { return m_msix_info.table_offset; }
 
     bool is_msi_capable() const { return m_msi_info.count > 0; }
-    bool is_msi_64bit_address_format() { return m_msi_info.message_address_64_bit_format; };
+    bool is_msi_64bit_address_format() { return m_msi_info.message_address_64_bit_format; }
 
     Spinlock<LockRank::None>& operation_lock() { return m_operation_lock; }
     Spinlock<LockRank::None>& operation_lock() const { return m_operation_lock; }

Kernel/Bus/PCI/Device.h

@@ -35,7 +35,7 @@ struct [[gnu::packed]] MSIxTableEntry {
 
 class Device {
 public:
-    DeviceIdentifier const& device_identifier() const { return *m_pci_identifier; };
+    DeviceIdentifier const& device_identifier() const { return *m_pci_identifier; }
 
     virtual ~Device() = default;
 

Kernel/Devices/GPU/Console/VGATextModeConsole.h

@@ -14,7 +14,7 @@ namespace Kernel::Graphics {
 class VGATextModeConsole final : public Console {
 public:
     static NonnullLockRefPtr<VGATextModeConsole> initialize();
-    virtual size_t chars_per_line() const override { return width(); };
+    virtual size_t chars_per_line() const override { return width(); }
 
     virtual bool has_hardware_cursor() const override { return true; }
     virtual bool is_hardware_paged_capable() const override { return true; }

Kernel/Devices/GPU/Management.h

@@ -30,7 +30,7 @@ public:
     static bool is_initialized();
     bool initialize();
 
-    unsigned allocate_minor_device_number() { return m_current_minor_number++; };
+    unsigned allocate_minor_device_number() { return m_current_minor_number++; }
     GraphicsManagement();
 
     void attach_new_display_connector(Badge<DisplayConnector>, DisplayConnector&);

Kernel/Devices/Storage/ATA/AHCI/Definitions.h

@@ -177,7 +177,7 @@ public:
         return indices;
     }
 
-    u32 bit_mask() const { return m_bit_mask; };
+    u32 bit_mask() const { return m_bit_mask; }
 
     // Disable default implementations that would use surprising integer promotion.
     bool operator==(MaskedBitField const&) const = delete;

Kernel/Devices/Storage/ATA/AHCI/Port.h

@@ -42,7 +42,7 @@ public:
     u32 port_index() const { return m_port_index; }
     u32 representative_port_index() const { return port_index() + 1; }
     bool is_operable() const;
-    bool is_atapi_attached() const { return m_port_registers.sig == (u32)ATA::DeviceSignature::ATAPI; };
+    bool is_atapi_attached() const { return m_port_registers.sig == (u32)ATA::DeviceSignature::ATAPI; }
 
     LockRefPtr<StorageDevice> connected_device() const { return m_connected_device; }
 
@@ -96,7 +96,7 @@ private:
 
     Optional<u8> try_to_find_unused_command_header();
 
-    ALWAYS_INLINE bool is_interface_disabled() const { return (m_port_registers.ssts & 0xf) == 4; };
+    ALWAYS_INLINE bool is_interface_disabled() const { return (m_port_registers.ssts & 0xf) == 4; }
 
     ALWAYS_INLINE void wait_until_condition_met_or_timeout(size_t delay_in_microseconds, size_t retries, Function<bool(void)> condition_being_met) const;
 

Kernel/Devices/Storage/ATA/ATAPort.cpp

@@ -24,7 +24,7 @@ public:
     ~ATAPortInterruptDisabler()
     {
         (void)m_port->enable_interrupts();
-    };
+    }
 
 private:
     LockRefPtr<ATAPort> m_port;
@@ -40,7 +40,7 @@ public:
     ~ATAPortInterruptCleaner()
     {
         (void)m_port->force_clear_interrupts();
-    };
+    }
 
 private:
     LockRefPtr<ATAPort> m_port;

Kernel/Devices/Storage/ATA/GenericIDE/Channel.h

@@ -77,7 +77,7 @@ public:
         bool operator<(IOWindowGroup const&) const = delete;
         bool operator>(IOWindowGroup const&) const = delete;
 
-        IOWindow& io_window() const { return *m_io_window; };
+        IOWindow& io_window() const { return *m_io_window; }
         IOWindow& control_window() const { return *m_control_window; }
         IOWindow* bus_master_window() const { return m_bus_master_window.ptr(); }
 

Kernel/Devices/Storage/NVMe/NVMeController.h

@@ -51,8 +51,8 @@ public:
         return 0;
     }
 
-    bool is_admin_queue_ready() { return m_admin_queue_ready; };
-    void set_admin_queue_ready_flag() { m_admin_queue_ready = true; };
+    bool is_admin_queue_ready() { return m_admin_queue_ready; }
+    void set_admin_queue_ready_flag() { m_admin_queue_ready = true; }
 
 private:
     NVMeController(PCI::DeviceIdentifier const&, u32 hardware_relative_controller_id);

Kernel/Devices/Storage/NVMe/NVMeInterruptQueue.h

@@ -17,7 +17,7 @@ public:
     static ErrorOr<NonnullLockRefPtr<NVMeInterruptQueue>> try_create(PCI::Device& device, NonnullOwnPtr<Memory::Region> rw_dma_region, NonnullRefPtr<Memory::PhysicalPage> rw_dma_page, u16 qid, u8 irq, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, OwnPtr<Memory::Region> sq_dma_region, Memory::TypedMapping<DoorbellRegister volatile> db_regs);
     void submit_sqe(NVMeSubmission& submission) override;
     virtual ~NVMeInterruptQueue() override {};
-    virtual StringView purpose() const override { return "NVMe"sv; };
+    virtual StringView purpose() const override { return "NVMe"sv; }
     void initialize_interrupt_queue();
 
 protected:

Kernel/Devices/Storage/NVMe/NVMeNameSpace.h

@@ -25,7 +25,7 @@ class NVMeNameSpace : public StorageDevice {
 public:
     static ErrorOr<NonnullLockRefPtr<NVMeNameSpace>> try_create(NVMeController const&, Vector<NonnullLockRefPtr<NVMeQueue>> queues, u16 nsid, size_t storage_size, size_t lba_size);
 
-    CommandSet command_set() const override { return CommandSet::NVMe; };
+    CommandSet command_set() const override { return CommandSet::NVMe; }
     void start_request(AsyncBlockDeviceRequest& request) override;
 
 private:

Kernel/Devices/Storage/NVMe/NVMeQueue.h

@@ -43,7 +43,7 @@ class NVMeController;
 class NVMeQueue : public AtomicRefCounted<NVMeQueue> {
 public:
     static ErrorOr<NonnullLockRefPtr<NVMeQueue>> try_create(NVMeController& device, u16 qid, u8 irq, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, OwnPtr<Memory::Region> sq_dma_region, Memory::TypedMapping<DoorbellRegister volatile> db_regs, QueueType queue_type);
-    bool is_admin_queue() { return m_admin_queue; };
+    bool is_admin_queue() { return m_admin_queue; }
     u16 submit_sync_sqe(NVMeSubmission&);
     void read(AsyncBlockDeviceRequest& request, u16 nsid, u64 index, u32 count);
     void write(AsyncBlockDeviceRequest& request, u16 nsid, u64 index, u32 count);

Kernel/FileSystem/BlockBasedFileSystem.h

@@ -17,7 +17,7 @@ public:
 
     virtual ~BlockBasedFileSystem() override;
 
-    u64 logical_block_size() const { return m_logical_block_size; };
+    u64 logical_block_size() const { return m_logical_block_size; }
 
     virtual void flush_writes() override;
     void flush_writes_impl();

Kernel/FileSystem/FATFS/FileSystem.h

@@ -41,7 +41,7 @@ private:
 
     static constexpr u32 first_data_cluster = 2;
 
-    FAT32BootRecord const* boot_record() const { return reinterpret_cast<FAT32BootRecord const*>(m_boot_record->data()); };
+    FAT32BootRecord const* boot_record() const { return reinterpret_cast<FAT32BootRecord const*>(m_boot_record->data()); }
 
     BlockBasedFileSystem::BlockIndex first_block_of_cluster(u32 cluster) const;
 

Kernel/FileSystem/Inode.h

@@ -107,7 +107,7 @@ public:
     ErrorOr<void> apply_flock(Process const&, OpenFileDescription const&, Userspace<flock const*>, ShouldBlock);
     ErrorOr<void> get_flock(OpenFileDescription const&, Userspace<flock*>) const;
     void remove_flocks_for_description(OpenFileDescription const&);
-    Thread::FlockBlockerSet& flock_blocker_set() { return m_flock_blocker_set; };
+    Thread::FlockBlockerSet& flock_blocker_set() { return m_flock_blocker_set; }
 
 protected:
     Inode(FileSystem&, InodeIndex);

Kernel/FileSystem/InodeWatcher.h

@@ -53,7 +53,7 @@ public:
     virtual ErrorOr<void> close() override;
 
     virtual ErrorOr<NonnullOwnPtr<KString>> pseudo_path(OpenFileDescription const&) const override;
-    virtual StringView class_name() const override { return "InodeWatcher"sv; };
+    virtual StringView class_name() const override { return "InodeWatcher"sv; }
     virtual bool is_inode_watcher() const override { return true; }
 
     void notify_inode_event(Badge<Inode>, InodeIdentifier, InodeWatcherEvent::Type, StringView name = {});

Kernel/FileSystem/SysFS/Component.h

@@ -31,7 +31,7 @@ public:
     virtual StringView name() const = 0;
     virtual ErrorOr<size_t> read_bytes(off_t, size_t, UserOrKernelBuffer&, OpenFileDescription*) const { return Error::from_errno(ENOTIMPL); }
     virtual ErrorOr<void> traverse_as_directory(FileSystemID, Function<ErrorOr<void>(FileSystem::DirectoryEntryView const&)>) const { VERIFY_NOT_REACHED(); }
-    virtual RefPtr<SysFSComponent> lookup(StringView) { VERIFY_NOT_REACHED(); };
+    virtual RefPtr<SysFSComponent> lookup(StringView) { VERIFY_NOT_REACHED(); }
     virtual mode_t permissions() const;
     virtual ErrorOr<void> truncate(u64) { return EPERM; }
     virtual size_t size() const { return 0; }
@@ -40,7 +40,7 @@ public:
 
     virtual ErrorOr<NonnullRefPtr<SysFSInode>> to_inode(SysFS const&) const;
 
-    InodeIndex component_index() const { return m_component_index; };
+    InodeIndex component_index() const { return m_component_index; }
 
     virtual ~SysFSComponent() = default;
 

Kernel/Heap/Heap.h

@@ -156,7 +156,7 @@ public:
 
     size_t total_chunks() const { return m_total_chunks; }
     size_t total_bytes() const { return m_total_chunks * CHUNK_SIZE; }
-    size_t free_chunks() const { return m_total_chunks - m_allocated_chunks; };
+    size_t free_chunks() const { return m_total_chunks - m_allocated_chunks; }
     size_t free_bytes() const { return free_chunks() * CHUNK_SIZE; }
     size_t allocated_chunks() const { return m_allocated_chunks; }
     size_t allocated_bytes() const { return m_allocated_chunks * CHUNK_SIZE; }

Kernel/Interrupts/GenericInterruptHandler.h

@@ -48,8 +48,8 @@ public:
 
     virtual bool eoi() = 0;
     void increment_call_count();
-    void set_reserved() { m_reserved = true; };
-    bool reserved() const { return m_reserved; };
+    void set_reserved() { m_reserved = true; }
+    bool reserved() const { return m_reserved; }
 
 protected:
     void change_interrupt_number(u8 number);

Kernel/Memory/Region.h

@@ -207,8 +207,8 @@ public:
     [[nodiscard]] bool mmapped_from_readable() const { return m_mmapped_from_readable; }
     [[nodiscard]] bool mmapped_from_writable() const { return m_mmapped_from_writable; }
 
-    void start_handling_page_fault(Badge<MemoryManager>) { m_in_progress_page_faults++; };
-    void finish_handling_page_fault(Badge<MemoryManager>) { m_in_progress_page_faults--; };
+    void start_handling_page_fault(Badge<MemoryManager>) { m_in_progress_page_faults++; }
+    void finish_handling_page_fault(Badge<MemoryManager>) { m_in_progress_page_faults--; }
 
 private:
     Region();

Kernel/Memory/RingBuffer.h

@@ -26,7 +26,7 @@ public:
     size_t used_bytes() const { return m_num_used_bytes; }
     PhysicalAddress start_of_region() const { return m_region->physical_page(0)->paddr(); }
     VirtualAddress vaddr() const { return m_region->vaddr(); }
-    size_t bytes_till_end() const { return (m_capacity_in_bytes - ((m_start_of_used + m_num_used_bytes) % m_capacity_in_bytes)) % m_capacity_in_bytes; };
+    size_t bytes_till_end() const { return (m_capacity_in_bytes - ((m_start_of_used + m_num_used_bytes) % m_capacity_in_bytes)) % m_capacity_in_bytes; }
 
 private:
     RingBuffer(NonnullOwnPtr<Memory::Region> region, size_t capacity);

Kernel/Net/IPv4SocketTuple.h

@@ -24,15 +24,15 @@ public:
         , m_peer_address(peer_address)
         , m_peer_port(peer_port) {};
 
-    IPv4Address local_address() const { return m_local_address; };
-    u16 local_port() const { return m_local_port; };
-    IPv4Address peer_address() const { return m_peer_address; };
-    u16 peer_port() const { return m_peer_port; };
+    IPv4Address local_address() const { return m_local_address; }
+    u16 local_port() const { return m_local_port; }
+    IPv4Address peer_address() const { return m_peer_address; }
+    u16 peer_port() const { return m_peer_port; }
 
     bool operator==(IPv4SocketTuple const& other) const
     {
         return other.local_address() == m_local_address && other.local_port() == m_local_port && other.peer_address() == m_peer_address && other.peer_port() == m_peer_port;
-    };
+    }
 
     ErrorOr<NonnullOwnPtr<KString>> to_string() const
     {

Kernel/Net/Intel/E1000NetworkAdapter.h

@@ -27,7 +27,7 @@ public:
     virtual ~E1000NetworkAdapter() override;
 
     virtual void send_raw(ReadonlyBytes) override;
-    virtual bool link_up() override { return m_link_up; };
+    virtual bool link_up() override { return m_link_up; }
     virtual i32 link_speed() override;
     virtual bool link_full_duplex() override;
 

Kernel/Security/Credentials.h

@@ -26,7 +26,7 @@ public:
     UserID suid() const { return m_suid; }
     GroupID sgid() const { return m_sgid; }
     ReadonlySpan<GroupID> extra_gids() const { return m_extra_gids.span(); }
-    SessionID sid() const { return m_sid; };
+    SessionID sid() const { return m_sid; }
     ProcessGroupID pgid() const { return m_pgid; }
 
     bool in_group(GroupID) const;

Kernel/Syscalls/execve.cpp

@@ -199,7 +199,7 @@ static ErrorOr<RequiredLoadRange> get_required_load_range(OpenFileDescription& p
 
     VERIFY(range.end > range.start);
     return range;
-};
+}
 
 static ErrorOr<FlatPtr> get_load_offset(const ElfW(Ehdr) & main_program_header, OpenFileDescription& main_program_description, OpenFileDescription* interpreter_description)
 {

Kernel/Syscalls/realpath.cpp

@@ -26,6 +26,6 @@ ErrorOr<FlatPtr> Process::sys$realpath(Userspace<Syscall::SC_realpath_params con
     TRY(copy_to_user(params.buffer.data, absolute_path->characters(), size_to_copy));
     // Note: we return the whole size here, not the copied size.
     return ideal_size;
-};
+}
 
 }

Kernel/Syscalls/uname.cpp

@@ -11,24 +11,25 @@
 
 namespace Kernel {
 
+#if ARCH(X86_64)
+#    define UNAME_MACHINE "x86_64"
+#elif ARCH(AARCH64)
+#    define UNAME_MACHINE "AArch64"
+#else
+#    error Unknown architecture
+#endif
+
 ErrorOr<FlatPtr> Process::sys$uname(Userspace<utsname*> user_buf)
 {
     VERIFY_NO_PROCESS_BIG_LOCK(this);
     TRY(require_promise(Pledge::stdio));
 
-    utsname buf
-    {
+    utsname buf {
         "SerenityOS",
-            {}, // Hostname, filled in below.
-            {}, // "Release" (1.0-dev), filled in below.
-            {}, // "Revision" (git commit hash), filled in below.
-#if ARCH(X86_64)
-            "x86_64",
-#elif ARCH(AARCH64)
-            "AArch64",
-#else
-#    error Unknown architecture
-#endif
+        {}, // Hostname, filled in below.
+        {}, // "Release" (1.0-dev), filled in below.
+        {}, // "Revision" (git commit hash), filled in below.
+        UNAME_MACHINE
     };
 
     auto version_string = TRY(KString::formatted("{}.{}-dev", SERENITY_MAJOR_REVISION, SERENITY_MINOR_REVISION));

Kernel/Tasks/FinalizerTask.cpp

@@ -24,7 +24,7 @@ static void finalizer_task(void*)
         else
             g_finalizer_wait_queue->wait_forever(finalizer_task_name);
     }
-};
+}
 
 UNMAP_AFTER_INIT void FinalizerTask::spawn()
 {

Kernel/Tasks/Process.cpp

@@ -1066,7 +1066,7 @@ ErrorOr<void> Process::try_set_coredump_property(StringView key, StringView valu
     auto key_kstring = TRY(KString::try_create(key));
     auto value_kstring = TRY(KString::try_create(value));
     return set_coredump_property(move(key_kstring), move(value_kstring));
-};
+}
 
 static constexpr StringView to_string(Pledge promise)
 {

Kernel/Tasks/Process.h

@@ -484,13 +484,13 @@ public:
     RefPtr<Custody> executable();
     RefPtr<Custody const> executable() const;
 
-    UnixDateTime creation_time() const { return m_creation_time; };
+    UnixDateTime creation_time() const { return m_creation_time; }
 
     static constexpr size_t max_arguments_size = Thread::default_userspace_stack_size / 8;
     static constexpr size_t max_environment_size = Thread::default_userspace_stack_size / 8;
     static constexpr size_t max_auxiliary_size = Thread::default_userspace_stack_size / 8;
-    Vector<NonnullOwnPtr<KString>> const& arguments() const { return m_arguments; };
-    Vector<NonnullOwnPtr<KString>> const& environment() const { return m_environment; };
+    Vector<NonnullOwnPtr<KString>> const& arguments() const { return m_arguments; }
+    Vector<NonnullOwnPtr<KString>> const& environment() const { return m_environment; }
 
     ErrorOr<void> exec(NonnullOwnPtr<KString> path, Vector<NonnullOwnPtr<KString>> arguments, Vector<NonnullOwnPtr<KString>> environment, Thread*& new_main_thread, InterruptsState& previous_interrupts_state, int recursion_depth = 0);
 

Kernel/Tasks/Thread.h

@@ -1066,7 +1066,7 @@ public:
 
     ErrorOr<NonnullOwnPtr<KString>> backtrace();
 
-    Blocker const* blocker() const { return m_blocker; };
+    Blocker const* blocker() const { return m_blocker; }
     Kernel::Mutex const* blocking_mutex() const { return m_blocking_mutex; }
 
 #if LOCK_DEBUG

Kernel/Time/TimerQueue.h

@@ -63,7 +63,7 @@ private:
     void clear_cancelled() { return m_cancelled.store(false, AK::memory_order_release); }
     bool set_cancelled() { return m_cancelled.exchange(true, AK::memory_order_acq_rel); }
 
-    bool is_in_use() { return m_in_use.load(AK::memory_order_acquire); };
+    bool is_in_use() { return m_in_use.load(AK::memory_order_acquire); }
     void set_in_use() { m_in_use.store(true, AK::memory_order_release); }
     void clear_in_use() { return m_in_use.store(false, AK::memory_order_release); }