RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:47:35 +00:00
Code Issues Activity Actions

LibWeb+WebContent: Virtualize PageClient methods needed for all clients

Browse source
This commit is contained in:
Timothy Flynn 2022-11-21 15:22:26 -05:00 • committed by Linus Groh
parent 1f08cb7020
commit c917a59abe
3 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/Page/Page.h
View file

@ -133,10 +133,13 @@ private:
class PageClient { class PageClient {
public: public:
virtual Page& page() = 0;
virtual Page const& page() const = 0;
virtual bool is_connection_open() const = 0; virtual bool is_connection_open() const = 0;
virtual Gfx::Palette palette() const = 0; virtual Gfx::Palette palette() const = 0;
virtual Gfx::IntRect screen_rect() const = 0; virtual Gfx::IntRect screen_rect() const = 0;
virtual CSS::PreferredColorScheme preferred_color_scheme() const = 0; virtual CSS::PreferredColorScheme preferred_color_scheme() const = 0;
virtual void paint(Gfx::IntRect const&, Gfx::Bitmap&) = 0;
virtual void page_did_change_title(String const&) { } virtual void page_did_change_title(String const&) { }
virtual void page_did_start_loading(const AK::URL&) { } virtual void page_did_start_loading(const AK::URL&) { }
virtual void page_did_create_main_document() { } virtual void page_did_create_main_document() { }

6
Userland/Services/WebContent/PageHost.h
View file

@ -23,10 +23,10 @@ public:
static NonnullOwnPtr<PageHost> create(ConnectionFromClient& client) { return adopt_own(*new PageHost(client)); } static NonnullOwnPtr<PageHost> create(ConnectionFromClient& client) { return adopt_own(*new PageHost(client)); }
virtual ~PageHost(); virtual ~PageHost();
Web::Page& page() { return *m_page; } virtual Web::Page& page() override { return *m_page; }
Web::Page const& page() const { return *m_page; } virtual Web::Page const& page() const override { return *m_page; }
void paint(Gfx::IntRect const& content_rect, Gfx::Bitmap&); virtual void paint(Gfx::IntRect const& content_rect, Gfx::Bitmap&) override;
void set_palette_impl(Gfx::PaletteImpl const&); void set_palette_impl(Gfx::PaletteImpl const&);
void set_viewport_rect(Gfx::IntRect const&); void set_viewport_rect(Gfx::IntRect const&);

6
Userland/Utilities/headless-browser.cpp
View file

@ -55,8 +55,8 @@ public:
return adopt_own(*new HeadlessBrowserPageClient()); return adopt_own(*new HeadlessBrowserPageClient());
} }
Web::Page& page() { return *m_page; } virtual Web::Page& page() override { return *m_page; }
Web::Page const& page() const { return *m_page; } virtual Web::Page const& page() const override { return *m_page; }
Web::Layout::InitialContainingBlock* layout_root() Web::Layout::InitialContainingBlock* layout_root()
{ {
@ -71,7 +71,7 @@ public:
page().load(url); page().load(url);
} }
void paint(Gfx::IntRect const& content_rect, Gfx::Bitmap& target) virtual void paint(Gfx::IntRect const& content_rect, Gfx::Bitmap& target) override
{ {
Gfx::Painter painter(target); Gfx::Painter painter(target);