From c93dfe8097ab17bc35de838f31572ef9a2537a6f Mon Sep 17 00:00:00 2001 From: Rummskartoffel Date: Sun, 23 Jan 2022 00:39:23 +0100 Subject: [PATCH] TextEditor: Fix crash on startup when file specified cannot be opened Due to a bug introduced in f674102, TE would attempt to access the value of an ErrorOr that didn't hold one, hitting an assertion. --- Userland/Applications/TextEditor/main.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Userland/Applications/TextEditor/main.cpp b/Userland/Applications/TextEditor/main.cpp index da086644c4..59c66e0e40 100644 --- a/Userland/Applications/TextEditor/main.cpp +++ b/Userland/Applications/TextEditor/main.cpp @@ -76,8 +76,11 @@ ErrorOr serenity_main(Main::Arguments arguments) FileArgument parsed_argument(file_to_edit); auto response = FileSystemAccessClient::Client::the().try_request_file_read_only_approved(window, parsed_argument.filename()); - if (response.is_error() && response.error().code() == ENOENT) { - text_widget->open_nonexistent_file(parsed_argument.filename()); + if (response.is_error()) { + if (response.error().code() == ENOENT) + text_widget->open_nonexistent_file(parsed_argument.filename()); + else + return 1; } else { if (!text_widget->read_file(*response.value())) return 1;