From c93f73c6171d71b4c328f34a4b48111bd16e7b89 Mon Sep 17 00:00:00 2001 From: NonStdModel Date: Fri, 11 Jun 2021 19:54:42 +0200 Subject: [PATCH] HackStudio: Remove unnecessary unveil in ShellLanguageServer Remove unveil on / with only browse permissions. Unveil will be sealed later when the root path of project is known. --- Userland/DevTools/HackStudio/LanguageServers/Cpp/main.cpp | 4 +++- Userland/DevTools/HackStudio/LanguageServers/Shell/main.cpp | 5 +---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Userland/DevTools/HackStudio/LanguageServers/Cpp/main.cpp b/Userland/DevTools/HackStudio/LanguageServers/Cpp/main.cpp index 6e404c6af7..dc19786c96 100644 --- a/Userland/DevTools/HackStudio/LanguageServers/Cpp/main.cpp +++ b/Userland/DevTools/HackStudio/LanguageServers/Cpp/main.cpp @@ -47,8 +47,10 @@ int mode_server() return 1; } - if (unveil("/usr/include", "r") < 0) + if (unveil("/usr/include", "r") < 0) { perror("unveil"); + return 1; + } // unveil will be sealed later, when we know the project's root path. return event_loop.exec(); diff --git a/Userland/DevTools/HackStudio/LanguageServers/Shell/main.cpp b/Userland/DevTools/HackStudio/LanguageServers/Shell/main.cpp index b348cf7ca9..5d47c1e640 100644 --- a/Userland/DevTools/HackStudio/LanguageServers/Shell/main.cpp +++ b/Userland/DevTools/HackStudio/LanguageServers/Shell/main.cpp @@ -31,9 +31,6 @@ int main(int, char**) perror("unveil"); return 1; } - if (unveil("/", "b") < 0) { - perror("unveil"); - return 1; - } + return event_loop.exec(); }