RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:17:35 +00:00
Code Issues Activity Actions

LibWeb: Make CSSStyleDeclaration support both dashed-name and camelCase

Browse source 
Turns out we need to support *both* of these styles since there's
content that uses one or both of these.
This commit is contained in:
Andreas Kling 2021-10-01 19:56:23 +02:00
parent 918b0b4394
commit c953103d2f
1 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/Bindings/CSSStyleDeclarationWrapperCustom.cpp
View file

@ -10,19 +10,29 @@
namespace Web::Bindings {
static CSS::PropertyID property_id_from_name(StringView name)
{
if (auto property_id = CSS::property_id_from_camel_case_string(name); property_id != CSS::PropertyID::Invalid)
return property_id;
if (auto property_id = CSS::property_id_from_string(name); property_id != CSS::PropertyID::Invalid)
return property_id;
return CSS::PropertyID::Invalid;
}
JS::ThrowCompletionOr<bool> CSSStyleDeclarationWrapper::internal_has_property(JS::PropertyName const& name) const
{
if (!name.is_string())
return Base::internal_has_property(name);
auto property_id = CSS::property_id_from_camel_case_string(name.to_string());
return property_id != CSS::PropertyID::Invalid;
return property_id_from_name(name.to_string()) != CSS::PropertyID::Invalid;
}
JS::ThrowCompletionOr<JS::Value> CSSStyleDeclarationWrapper::internal_get(JS::PropertyName const& name, JS::Value receiver) const
{
if (!name.is_string())
return Base::internal_get(name, receiver);
auto property_id = CSS::property_id_from_camel_case_string(name.to_string());
auto property_id = property_id_from_name(name.to_string());
if (property_id == CSS::PropertyID::Invalid)
return Base::internal_get(name, receiver);
if (auto maybe_property = impl().property(property_id); maybe_property.has_value())
@ -34,7 +44,7 @@ JS::ThrowCompletionOr<bool> CSSStyleDeclarationWrapper::internal_set(JS::Propert
{
if (!name.is_string())
return Base::internal_set(name, value, receiver);
auto property_id = CSS::property_id_from_camel_case_string(name.to_string());
auto property_id = property_id_from_name(name.to_string());
if (property_id == CSS::PropertyID::Invalid)
return Base::internal_set(name, value, receiver);