RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:57:34 +00:00
Code Issues Activity Actions

LibWeb: Fix grid size when intrinsically sized

Browse source 
This fixes a bug that was seen when a combination of the grid having
been floated with `float: left` and a `minmax()` column size were used.

The issue was that a grid track size should be considered intrinsically
sized if both the min and max sizes are intrinsic, not just one of them.
This commit is contained in:
martinfalisse 2023-04-23 17:03:12 +02:00 • committed by Andreas Kling
parent 9f691b7fe4
commit c987c934d0
5 changed files with 67 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Tests/LibWeb/Layout/expected/grid/intrinsic-sized-column.txt Normal file
View file

@ -0,0 +1,14 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x35.46875 children: inline
TextNode <#text>
BlockContainer <body> at (8,8) content-size 0x19.46875 floating children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 0x0 children: inline
TextNode <#text>
Box <div.grid> at (8,8) content-size 0x19.46875 children: not-inline
BlockContainer <(anonymous)> children: inline
TextNode <#text>
BlockContainer <div.whee> at (9,9) content-size 18x17.46875 children: inline
line 0 width: 37.953125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [9,9 37.953125x17.46875]
"whee"
TextNode <#text>

9
Tests/LibWeb/Layout/expected/grid/intrinsic-sized-grid.txt Normal file
View file

@ -0,0 +1,9 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x39.46875 children: not-inline
BlockContainer <body> at (10,10) content-size 2x21.46875 floating children: not-inline
Box <div.grid> at (11,11) content-size 0x19.46875 children: not-inline
BlockContainer <div.whee> at (12,12) content-size 35.953125x17.46875 children: inline
line 0 width: 37.953125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [12,12 37.953125x17.46875]
"whee"
TextNode <#text>