RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:28:11 +00:00
Code Issues Activity Actions

LibWeb: Fix grid size when intrinsically sized

Browse source 
This fixes a bug that was seen when a combination of the grid having
been floated with `float: left` and a `minmax()` column size were used.

The issue was that a grid track size should be considered intrinsically
sized if both the min and max sizes are intrinsic, not just one of them.
This commit is contained in:
martinfalisse 2023-04-23 17:03:12 +02:00 • committed by Andreas Kling
parent 9f691b7fe4
commit c987c934d0
5 changed files with 67 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp
View file

@ -753,7 +753,7 @@ void GridFormattingContext::calculate_sizes_of_columns(Box const& box, Available
}
}
if (!grid_column.min_track_sizing_function.is_intrinsic_track_sizing()) {
if (!grid_column.min_track_sizing_function.is_intrinsic_track_sizing() && !grid_column.max_track_sizing_function.is_intrinsic_track_sizing()) {
++index;
continue;
}
@ -1257,7 +1257,7 @@ void GridFormattingContext::calculate_sizes_of_rows(Box const& box)
}
}
if (!grid_row.min_track_sizing_function.is_intrinsic_track_sizing()) {
if (!grid_row.min_track_sizing_function.is_intrinsic_track_sizing() && !grid_row.max_track_sizing_function.is_intrinsic_track_sizing()) {
++index;
continue;
}