RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:57:45 +00:00
Code Issues Activity Actions

Userland: Add more TODO()s for arch-specific code

Browse source 
This enables building more of the userspace applications for x86_64.
This commit is contained in:
Gunnar Beutner 2021-06-23 21:47:19 +02:00 • committed by Andreas Kling
parent f2d6cac692
commit c9a8dfa1bf
5 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibDebug/DebugSession.cpp
View file

@ -9,6 +9,7 @@
#include <AK/JsonValue.h>
#include <AK/LexicalPath.h>
#include <AK/Optional.h>
#include <AK/Platform.h>
#include <LibCore/File.h>
#include <LibRegex/Regex.h>
#include <stdlib.h>
@ -336,7 +337,11 @@ void* DebugSession::single_step()
regs = get_registers();
regs.eflags &= ~(TRAP_FLAG);
set_registers(regs);
#if ARCH(I386)
return (void*)regs.eip;
#else
TODO();
#endif
}
void DebugSession::detach()

4
Userland/Libraries/LibDebug/Dwarf/Expression.cpp
View file

@ -12,7 +12,7 @@
namespace Debug::Dwarf::Expression {
Value evaluate(ReadonlyBytes bytes, PtraceRegisters const& regs)
Value evaluate(ReadonlyBytes bytes, [[maybe_unused]] PtraceRegisters const& regs)
{
InputMemoryStream stream(bytes);
@ -21,6 +21,7 @@ Value evaluate(ReadonlyBytes bytes, PtraceRegisters const& regs)
stream >> opcode;
switch (static_cast<Operations>(opcode)) {
#if ARCH(I386)
case Operations::RegEbp: {
ssize_t offset = 0;
stream.read_LEB128_signed(offset);
@ -32,6 +33,7 @@ Value evaluate(ReadonlyBytes bytes, PtraceRegisters const& regs)
stream.read_LEB128_signed(offset);
return Value { Type::UnsignedIntetger, regs.ebp + 2 * sizeof(size_t) + offset };
}
#endif
default:
dbgln("DWARF expr addr: {}", (const void*)bytes.data());