From c9bdd59e200395f2eeb021e92ea0f02325048461 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Sun, 1 May 2022 01:24:05 +0200 Subject: [PATCH] LibJS: Change "Completion {}" to "Completion Record {}" in comments This is an editorial change in the ECMA-262 spec. See: https://github.com/tc39/ecma262/commit/15a7d8a --- Userland/Libraries/LibJS/AST.cpp | 16 ++++++++-------- Userland/Libraries/LibJS/Runtime/Completion.h | 2 +- .../LibJS/Runtime/ECMAScriptFunctionObject.cpp | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Userland/Libraries/LibJS/AST.cpp b/Userland/Libraries/LibJS/AST.cpp index 4af93beb83..afe61b6a2a 100644 --- a/Userland/Libraries/LibJS/AST.cpp +++ b/Userland/Libraries/LibJS/AST.cpp @@ -511,7 +511,7 @@ Completion ReturnStatement::execute(Interpreter& interpreter, GlobalObject& glob // ReturnStatement : return ; if (!m_argument) { - // 1. Return Completion { [[Type]]: return, [[Value]]: undefined, [[Target]]: empty }. + // 1. Return Completion Record { [[Type]]: return, [[Value]]: undefined, [[Target]]: empty }. return { Completion::Type::Return, js_undefined(), {} }; } @@ -523,7 +523,7 @@ Completion ReturnStatement::execute(Interpreter& interpreter, GlobalObject& glob // NOTE: Generators are not supported in the AST interpreter // 3. If ! GetGeneratorKind() is async, set exprValue to ? Await(exprValue). - // 4. Return Completion { [[Type]]: return, [[Value]]: exprValue, [[Target]]: empty }. + // 4. Return Completion Record { [[Type]]: return, [[Value]]: exprValue, [[Target]]: empty }. return { Completion::Type::Return, value, {} }; } @@ -1004,7 +1004,7 @@ Completion ForInStatement::loop_evaluation(Interpreter& interpreter, GlobalObjec // a. If exprValue is undefined or null, then if (rhs_result.is_nullish()) { - // i. Return Completion { [[Type]]: break, [[Value]]: empty, [[Target]]: empty }. + // i. Return Completion Record { [[Type]]: break, [[Value]]: empty, [[Target]]: empty }. return { Completion::Type::Break, {}, {} }; } @@ -1600,7 +1600,7 @@ public: // b. Let value be ? GetValue(rhs). auto value = TRY(interpreter.vm().named_evaluation_if_anonymous_function(global_object, m_expression, m_class_field_identifier_name)); - // 5. Return Completion { [[Type]]: return, [[Value]]: value, [[Target]]: empty }. + // 5. Return Completion Record { [[Type]]: return, [[Value]]: value, [[Target]]: empty }. return { Completion::Type::Return, value, {} }; } @@ -3971,13 +3971,13 @@ Completion BreakStatement::execute(Interpreter& interpreter, GlobalObject&) cons // BreakStatement : break ; if (m_target_label.is_null()) { - // 1. Return Completion { [[Type]]: break, [[Value]]: empty, [[Target]]: empty }. + // 1. Return Completion Record { [[Type]]: break, [[Value]]: empty, [[Target]]: empty }. return { Completion::Type::Break, {}, {} }; } // BreakStatement : break LabelIdentifier ; // 1. Let label be the StringValue of LabelIdentifier. - // 2. Return Completion { [[Type]]: break, [[Value]]: empty, [[Target]]: label }. + // 2. Return Completion Record { [[Type]]: break, [[Value]]: empty, [[Target]]: label }. return { Completion::Type::Break, {}, m_target_label }; } @@ -3988,13 +3988,13 @@ Completion ContinueStatement::execute(Interpreter& interpreter, GlobalObject&) c // ContinueStatement : continue ; if (m_target_label.is_null()) { - // 1. Return Completion { [[Type]]: continue, [[Value]]: empty, [[Target]]: empty }. + // 1. Return Completion Record { [[Type]]: continue, [[Value]]: empty, [[Target]]: empty }. return { Completion::Type::Continue, {}, {} }; } // ContinueStatement : continue LabelIdentifier ; // 1. Let label be the StringValue of LabelIdentifier. - // 2. Return Completion { [[Type]]: continue, [[Value]]: empty, [[Target]]: label }. + // 2. Return Completion Record { [[Type]]: continue, [[Value]]: empty, [[Target]]: label }. return { Completion::Type::Continue, {}, m_target_label }; } diff --git a/Userland/Libraries/LibJS/Runtime/Completion.h b/Userland/Libraries/LibJS/Runtime/Completion.h index 52322e9b4c..c9f3c29e96 100644 --- a/Userland/Libraries/LibJS/Runtime/Completion.h +++ b/Userland/Libraries/LibJS/Runtime/Completion.h @@ -84,7 +84,7 @@ public: if (m_value.has_value()) return *this; - // 3. Return Completion { [[Type]]: completionRecord.[[Type]], [[Value]]: value, [[Target]]: completionRecord.[[Target]] }. + // 3. Return Completion Record { [[Type]]: completionRecord.[[Type]], [[Value]]: value, [[Target]]: completionRecord.[[Target]] }. return { m_type, move(value), m_target }; } diff --git a/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp b/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp index 17a93a60f9..f81d29d108 100644 --- a/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp +++ b/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp @@ -868,7 +868,7 @@ Completion ECMAScriptFunctionObject::ordinary_call_evaluate_body() MUST(call(global_object(), promise_capability.reject, js_undefined(), *declaration_result.throw_completion().value())); } - // 5. Return Completion { [[Type]]: return, [[Value]]: promiseCapability.[[Promise]], [[Target]]: empty }. + // 5. Return Completion Record { [[Type]]: return, [[Value]]: promiseCapability.[[Promise]], [[Target]]: empty }. return Completion { Completion::Type::Return, promise_capability.promise, {} }; } }