RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:37:45 +00:00
Code Issues Activity Actions

LibCore: Make all processes opt out of InspectorServer by default

Browse source 
This functionality, while neat, isn't really something you need enabled
all the time. Let's make it opt-in instead. Pass MakeInspectable::Yes
to the Core::EventLoop constructor if you want your program to become
inspectable.
This commit is contained in:
Andreas Kling 2021-05-22 23:26:51 +02:00
parent 76a07b31e4
commit c9e849a968
4 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCore/EventLoop.h
View file

@ -26,7 +26,7 @@ public:
Yes, Yes,
}; };
EventLoop(MakeInspectable = MakeInspectable::Yes); explicit EventLoop(MakeInspectable = MakeInspectable::No);
~EventLoop(); ~EventLoop();
int exec(); int exec();

2
Userland/Services/InspectorServer/main.cpp
View file

@ -12,7 +12,7 @@
int main(int, char**) int main(int, char**)
{ {
Core::EventLoop event_loop(Core::EventLoop::MakeInspectable::No); Core::EventLoop event_loop;
auto server = Core::LocalServer::construct(); auto server = Core::LocalServer::construct();
if (pledge("stdio unix accept", nullptr) < 0) { if (pledge("stdio unix accept", nullptr) < 0) {

3
Userland/Services/WindowServer/EventLoop.cpp
View file

@ -27,8 +27,7 @@
namespace WindowServer { namespace WindowServer {
EventLoop::EventLoop() EventLoop::EventLoop()
: m_event_loop(Core::EventLoop::MakeInspectable::No) : m_window_server(Core::LocalServer::construct())
, m_window_server(Core::LocalServer::construct())
, m_wm_server(Core::LocalServer::construct()) , m_wm_server(Core::LocalServer::construct())
{ {
m_keyboard_fd = open("/dev/keyboard0", O_RDONLY | O_NONBLOCK | O_CLOEXEC); m_keyboard_fd = open("/dev/keyboard0", O_RDONLY | O_NONBLOCK | O_CLOEXEC);

2
Userland/Utilities/bt.cpp
View file

@ -27,7 +27,7 @@ int main(int argc, char** argv)
pid_t pid = 0; pid_t pid = 0;
args_parser.add_positional_argument(pid, "PID", "pid"); args_parser.add_positional_argument(pid, "PID", "pid");
args_parser.parse(argc, argv); args_parser.parse(argc, argv);
Core::EventLoop loop(Core::EventLoop::MakeInspectable::No); Core::EventLoop loop;
Core::DirIterator iterator(String::formatted("/proc/{}/stacks", pid), Core::DirIterator::SkipDots); Core::DirIterator iterator(String::formatted("/proc/{}/stacks", pid), Core::DirIterator::SkipDots);
if (iterator.has_error()) { if (iterator.has_error()) {