From ca3e0288e93a899677e2771c880f81177f3b8555 Mon Sep 17 00:00:00 2001
From: Sam Atkins <atkinssj@serenityos.org>
Date: Wed, 19 Jul 2023 15:03:47 +0100
Subject: [PATCH] GMLPlayground: Keep a RefPtr to the "Save As..." action

Previously, the Save action held a reference to the local variable for
the Save As action, which goes out of scope at the end of
`initialize_menubar()`. This meant that if you tried to Save a new
file, it would instead crash and yeet your work into the abyss.
---
 Userland/DevTools/GMLPlayground/MainWidget.cpp | 8 ++++----
 Userland/DevTools/GMLPlayground/MainWidget.h   | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/Userland/DevTools/GMLPlayground/MainWidget.cpp b/Userland/DevTools/GMLPlayground/MainWidget.cpp
index bfa729988f..ca44ef0d5b 100644
--- a/Userland/DevTools/GMLPlayground/MainWidget.cpp
+++ b/Userland/DevTools/GMLPlayground/MainWidget.cpp
@@ -136,7 +136,7 @@ ErrorOr<void> MainWidget::initialize_menubar(GUI::Window& window)
 {
     auto file_menu = TRY(window.try_add_menu("&File"_short_string));
 
-    auto save_as_action = GUI::CommonActions::make_save_as_action([&](auto&) {
+    m_save_as_action = GUI::CommonActions::make_save_as_action([&](auto&) {
         LexicalPath initial_path(m_file_path.is_empty() ? "Untitled.gml" : m_file_path);
         auto response = FileSystemAccessClient::Client::the().save_file(&window, initial_path.title(), initial_path.extension());
         if (response.is_error())
@@ -155,7 +155,7 @@ ErrorOr<void> MainWidget::initialize_menubar(GUI::Window& window)
 
     m_save_action = GUI::CommonActions::make_save_action([&](auto&) {
         if (m_file_path.is_empty()) {
-            save_as_action->activate();
+            m_save_as_action->activate();
             return;
         }
         auto response = FileSystemAccessClient::Client::the().request_file(&window, m_file_path, Core::File::OpenMode::Truncate | Core::File::OpenMode::Write);
@@ -189,7 +189,7 @@ ErrorOr<void> MainWidget::initialize_menubar(GUI::Window& window)
 
     TRY(file_menu->try_add_action(open_action));
     TRY(file_menu->try_add_action(*m_save_action));
-    TRY(file_menu->try_add_action(save_as_action));
+    TRY(file_menu->try_add_action(*m_save_as_action));
     TRY(file_menu->try_add_separator());
 
     TRY(file_menu->add_recent_files_list([&](auto& action) {
@@ -281,7 +281,7 @@ ErrorOr<void> MainWidget::initialize_menubar(GUI::Window& window)
 
     (void)TRY(m_toolbar->try_add_action(open_action));
     (void)TRY(m_toolbar->try_add_action(*m_save_action));
-    (void)TRY(m_toolbar->try_add_action(save_as_action));
+    (void)TRY(m_toolbar->try_add_action(*m_save_as_action));
     TRY(m_toolbar->try_add_separator());
     (void)TRY(m_toolbar->try_add_action(m_editor->cut_action()));
     (void)TRY(m_toolbar->try_add_action(m_editor->copy_action()));
diff --git a/Userland/DevTools/GMLPlayground/MainWidget.h b/Userland/DevTools/GMLPlayground/MainWidget.h
index da4d2f28c5..a333855101 100644
--- a/Userland/DevTools/GMLPlayground/MainWidget.h
+++ b/Userland/DevTools/GMLPlayground/MainWidget.h
@@ -35,6 +35,7 @@ private:
     virtual void drop_event(GUI::DropEvent&) override;
 
     RefPtr<GUI::Action> m_save_action;
+    RefPtr<GUI::Action> m_save_as_action;
     RefPtr<GUI::TextEditor> m_editor;
     RefPtr<GUI::Toolbar> m_toolbar;
     RefPtr<GUI::Splitter> m_splitter;