RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-23 23:25:06 +00:00
Code Issues Activity Actions

LibWeb: Do not crash if "fill: none" is specified for svg text

Browse source
This commit is contained in:
Aliaksandr Kalenik 2023-07-13 13:41:12 +02:00 • committed by Andreas Kling
parent e2c5e31292
commit ca50da63e4
3 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Layout/expected/svg/text-fill-none.txt Normal file
View file

@ -0,0 +1,8 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x163 children: inline
line 0 width: 300, height: 163, bottom: 163, baseline: 13.53125
frag 0 from SVGSVGBox start: 0, length: 0, rect: [8,21 300x150]
SVGSVGBox <svg> at (8,21) content-size 300x150 [SVG] children: not-inline
SVGTextBox <text> at (8,21) content-size 0x0 children: not-inline
TextNode <#text>

1
Tests/LibWeb/Layout/input/svg/text-fill-none.html Normal file
View file

@ -0,0 +1 @@
<svg><text fill="none"></text></svg>
Side by side

After

Width:  |  Height:  |  Size: 37 B

3
Userland/Libraries/LibWeb/Painting/SVGTextPaintable.cpp
View file

@ -31,6 +31,9 @@ void SVGTextPaintable::paint(PaintContext& context, PaintPhase phase) const
if (!is_visible()) if (!is_visible())
return; return;
if (!layout_node().computed_values().fill().has_value())
return;
SVGGraphicsPaintable::paint(context, phase); SVGGraphicsPaintable::paint(context, phase);
if (phase != PaintPhase::Foreground) if (phase != PaintPhase::Foreground)