RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:27:45 +00:00
Code Issues Activity Actions

FontEditor: Correct NewFontDialog layout issues

Browse source 
Fixes incorrect scale initialization and inconsistent margins, sets
minimum values for glyph width and height to 1, and labels page 1
more precisely as "Typeface" properties.
This commit is contained in:
thankyouverycool 2021-11-29 11:01:50 -05:00 • committed by Andreas Kling
parent 9b184fc1cb
commit ca77aea099
2 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/FontEditor/NewFontDialog.cpp
View file

@ -111,7 +111,7 @@ private:
update(); update();
} }
int m_scale { 20 }; int m_scale { 10 };
int m_width { 20 }; int m_width { 20 };
int m_height { 20 }; int m_height { 20 };
int m_glyph_width { 20 }; int m_glyph_width { 20 };
@ -127,7 +127,7 @@ NewFontDialog::NewFontDialog(GUI::Window* parent_window)
{ {
set_title("New Font"); set_title("New Font");
m_font_properties_page = GUI::WizardPage::construct("Font properties", "Edit details about this font."); m_font_properties_page = GUI::WizardPage::construct("Typeface properties", "Edit details about this font.");
m_font_properties_page->body_widget().load_from_gml(new_font_dialog_page_1_gml); m_font_properties_page->body_widget().load_from_gml(new_font_dialog_page_1_gml);
m_name_textbox = m_font_properties_page->body_widget().find_descendant_of_type_named<GUI::TextBox>("name_textbox"); m_name_textbox = m_font_properties_page->body_widget().find_descendant_of_type_named<GUI::TextBox>("name_textbox");

13
Userland/Applications/FontEditor/NewFontDialogPage2.gml
View file

@ -11,7 +11,7 @@
title: "Metadata" title: "Metadata"
fixed_width: 200 fixed_width: 200
layout: @GUI::VerticalBoxLayout { layout: @GUI::VerticalBoxLayout {
margins: [4] margins: [6]
} }
@GUI::Widget { @GUI::Widget {
@ -26,7 +26,7 @@
@GUI::SpinBox { @GUI::SpinBox {
name: "height_spinbox" name: "height_spinbox"
min: 0 min: 1
} }
} }
@ -42,7 +42,7 @@
@GUI::SpinBox { @GUI::SpinBox {
name: "width_spinbox" name: "width_spinbox"
min: 0 min: 1
} }
} }
@ -104,14 +104,15 @@
layout: @GUI::HorizontalBoxLayout { layout: @GUI::HorizontalBoxLayout {
} }
@GUI::Widget {
fixed_width: 80
}
@GUI::CheckBox { @GUI::CheckBox {
name: "fixed_width_checkbox" name: "fixed_width_checkbox"
text: "Fixed width" text: "Fixed width"
autosize: true autosize: true
} }
@GUI::Widget {
}
} }
} }