RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:48:14 +00:00
Code Issues Activity Actions

LibGUI: Turn GUI::Application::the() into a pointer

Browse source 
During app teardown, the Application object may be destroyed before
something else, and so having Application::the() return a reference was
obscuring the truth about its lifetime.

This patch makes the API more honest by returning a pointer. While
this makes call sites look a bit more sketchy, do note that the global
Application pointer only becomes null during app teardown.
This commit is contained in:
Andreas Kling 2020-07-04 16:52:01 +02:00
parent f7577585a6
commit ca93c22ae2
26 changed files with 51 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibGUI/Window.cpp
View file

@ -113,7 +113,7 @@ void Window::show()
apply_icon();
reified_windows->set(m_window_id, this);
Application::the().did_create_window({});
Application::the()->did_create_window({});
update();
}
@ -158,7 +158,7 @@ void Window::hide()
}
}
if (!app_has_visible_windows)
Application::the().did_delete_last_window({});
Application::the()->did_delete_last_window({});
}
void Window::set_title(const StringView& title)