From ca9592d56ffa3f8b01603df020fb8327756eac2b Mon Sep 17 00:00:00 2001
From: Andreas Kling <awesomekling@gmail.com>
Date: Tue, 13 Aug 2019 12:59:58 +0200
Subject: [PATCH] LibVT: Shave down VT::Attribute from 8 bytes to 3 bytes

We have one of these per character in the terminal buffers, so it's a
decent haircut. :^)
---
 Libraries/LibVT/Terminal.cpp | 3 ---
 Libraries/LibVT/Terminal.h   | 8 ++++----
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/Libraries/LibVT/Terminal.cpp b/Libraries/LibVT/Terminal.cpp
index d0656667d3..4b2cd501f8 100644
--- a/Libraries/LibVT/Terminal.cpp
+++ b/Libraries/LibVT/Terminal.cpp
@@ -3,9 +3,6 @@
 
 namespace VT {
 
-u8 Attribute::default_foreground_color = 7;
-u8 Attribute::default_background_color = 0;
-
 Terminal::Terminal(TerminalClient& client)
     : m_client(client)
 {
diff --git a/Libraries/LibVT/Terminal.h b/Libraries/LibVT/Terminal.h
index d0cc82ca1e..f52eda5e2a 100644
--- a/Libraries/LibVT/Terminal.h
+++ b/Libraries/LibVT/Terminal.h
@@ -19,8 +19,8 @@ public:
 struct Attribute {
     Attribute() { reset(); }
 
-    static u8 default_foreground_color;
-    static u8 default_background_color;
+    static const u8 default_foreground_color = 7;
+    static const u8 default_background_color = 0;
 
     void reset()
     {
@@ -31,7 +31,7 @@ struct Attribute {
     u8 foreground_color;
     u8 background_color;
 
-    enum Flags {
+    enum Flags : u8 {
         NoAttributes = 0x00,
         Bold = 0x01,
         Italic = 0x02,
@@ -45,7 +45,7 @@ struct Attribute {
 
     // TODO: it would be really nice if we had a helper for enums that
     // exposed bit ops for class enums...
-    int flags = Flags::NoAttributes;
+    u8 flags = Flags::NoAttributes;
 
     bool operator==(const Attribute& other) const
     {