RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:47:44 +00:00
Code Issues Activity Actions

LibJS: Rename ErrorType::ToObjectNullOr{Undef => Undefined}

Browse source 
This seems like an unnecessary and uncommon abbreviation.
This commit is contained in:
Linus Groh 2021-01-13 20:34:44 +01:00 • committed by Andreas Kling
parent f67f8fdbf2
commit cab3049dcc
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/ErrorTypes.h
View file

@ -155,7 +155,7 @@
M(StringRepeatCountMustBe, "repeat count must be a {} number") \ M(StringRepeatCountMustBe, "repeat count must be a {} number") \
M(ThisHasNotBeenInitialized, "|this| has not been initialized") \ M(ThisHasNotBeenInitialized, "|this| has not been initialized") \
M(ThisIsAlreadyInitialized, "|this| is already initialized") \ M(ThisIsAlreadyInitialized, "|this| is already initialized") \
M(ToObjectNullOrUndef, "ToObject on null or undefined") \ M(ToObjectNullOrUndefined, "ToObject on null or undefined") \
M(TypedArrayInvalidBufferLength, "Invalid buffer length for {}: must be a multiple of {}, got {}") \ M(TypedArrayInvalidBufferLength, "Invalid buffer length for {}: must be a multiple of {}, got {}") \
M(TypedArrayInvalidByteOffset, "Invalid byte offset for {}: must be a multiple of {}, got {}") \ M(TypedArrayInvalidByteOffset, "Invalid byte offset for {}: must be a multiple of {}, got {}") \
M(TypedArrayOutOfRangeByteOffset, "Typed array byte offset {} is out of range for buffer with length {}") \ M(TypedArrayOutOfRangeByteOffset, "Typed array byte offset {} is out of range for buffer with length {}") \

2
Userland/Libraries/LibJS/Runtime/StringPrototype.cpp
View file

@ -616,7 +616,7 @@ JS_DEFINE_NATIVE_FUNCTION(StringPrototype::symbol_iterator)
{ {
auto this_object = vm.this_value(global_object); auto this_object = vm.this_value(global_object);
if (this_object.is_nullish()) { if (this_object.is_nullish()) {
vm.throw_exception<TypeError>(global_object, ErrorType::ToObjectNullOrUndef); vm.throw_exception<TypeError>(global_object, ErrorType::ToObjectNullOrUndefined);
return {}; return {};
} }

2
Userland/Libraries/LibJS/Runtime/Value.cpp
View file

@ -355,7 +355,7 @@ Object* Value::to_object(GlobalObject& global_object) const
switch (m_type) { switch (m_type) {
case Type::Undefined: case Type::Undefined:
case Type::Null: case Type::Null:
global_object.vm().throw_exception<TypeError>(global_object, ErrorType::ToObjectNullOrUndef); global_object.vm().throw_exception<TypeError>(global_object, ErrorType::ToObjectNullOrUndefined);
return nullptr; return nullptr;
case Type::Boolean: case Type::Boolean:
return BooleanObject::create(global_object, m_value.as_bool); return BooleanObject::create(global_object, m_value.as_bool);