RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:37:46 +00:00
Code Issues Activity Actions

LibWeb: Add support for parsing 'inset' shorthand CSS property

Browse source
This commit is contained in:
FalseHonesty 2023-05-29 21:43:37 -04:00 • committed by Andreas Kling
parent e129c8049b
commit cabfb7867c
4 changed files with 72 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Tests/LibWeb/Layout/expected/inset-shorthand-property.txt Normal file
View file

@ -0,0 +1,15 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x216 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x200 children: not-inline
BlockContainer <div.parent> at (8,8) content-size 200x200 positioned children: inline
TextNode <#text>
BlockContainer <div.bad> at (38,18) content-size 150x150 positioned [BFC] children: inline
line 0 width: 26.546875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [38,18 26.546875x17.46875]
"Bad"
TextNode <#text>
TextNode <#text>
BlockContainer <div.good> at (38,18) content-size 150x150 positioned [BFC] children: not-inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,208) content-size 784x0 children: inline
TextNode <#text>

25
Tests/LibWeb/Layout/input/inset-shorthand-property.html Normal file
View file

@ -0,0 +1,25 @@
<!DOCTYPE html><style>
.parent {
width: 200px;
height: 200px;
background: grey;
position: relative;
}
.bad {
position: absolute;
background-color: red;
top: 10px;
right: 20px;
bottom: 40px;
left: 30px;
}
.good {
position: absolute;
inset: 10px 20px 40px 30px;
background-color: green;
}
</style>
<div class="parent">
<div class="bad">Bad</div>
<div class="good"></div>
</div>

18
Userland/Libraries/LibWeb/CSS/Properties.json
View file

@ -1151,6 +1151,24 @@
"image-rendering" "image-rendering"
] ]
}, },
"inset": {
"inherited": false,
"initial": "auto",
"longhands": [
"top",
"right",
"bottom",
"left"
],
"max-values": 4,
"valid-types": [
"length",
"percentage"
],
"valid-identifiers": [
"auto"
]
},
"justify-content": { "justify-content": {
"inherited": false, "inherited": false,
"initial": "flex-start", "initial": "flex-start",

14
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -516,6 +516,20 @@ static void set_property_expanding_shorthands(StyleProperties& style, CSS::Prope
return; return;
} }
if (property_id == CSS::PropertyID::Inset) {
if (value.is_value_list()) {
auto const& values_list = value.as_value_list();
assign_edge_values(PropertyID::Top, PropertyID::Right, PropertyID::Bottom, PropertyID::Left, values_list.values());
return;
}
style.set_property(CSS::PropertyID::Top, value, declaration);
style.set_property(CSS::PropertyID::Right, value, declaration);
style.set_property(CSS::PropertyID::Bottom, value, declaration);
style.set_property(CSS::PropertyID::Left, value, declaration);
return;
}
if (property_id == CSS::PropertyID::Margin) { if (property_id == CSS::PropertyID::Margin) {
if (value.is_value_list()) { if (value.is_value_list()) {
auto const& values_list = value.as_value_list(); auto const& values_list = value.as_value_list();