mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 03:17:34 +00:00
SystemMonitor: Consistently use u64 for ValueFormat::text_formatter
ValueFormat::text_formatter is called with a u64 retrieved from GraphWidget::m_values. However, the function pointer definition used size_t and all the users of text_formatter used int. If bytes was over ~2 billion, we would interpret bytes to be negative. We then pass this into `human_readable_size` which converts it to a u64, making it out to be about 15.9 EiB. This is fixed by making everything in the path take a u64.
This commit is contained in:
parent
b96b2fb9be
commit
caf652799f
2 changed files with 6 additions and 6 deletions
|
@ -26,7 +26,7 @@ public:
|
|||
struct ValueFormat {
|
||||
Gfx::ColorRole graph_color_role { Gfx::ColorRole::Base };
|
||||
Color text_shadow_color { Color::Transparent };
|
||||
Function<String(size_t)> text_formatter;
|
||||
Function<String(u64)> text_formatter;
|
||||
};
|
||||
void set_value_format(size_t index, ValueFormat&& format)
|
||||
{
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue