RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:28:11 +00:00
Code Issues Activity Actions

Userland+LibCore: Remove legacy SERENITY_VERSION from Core::Version

Browse source 
This was being used as a default version argument in a couple of APIs,
so those need to change signature and the caller always needs to provide
a version.
This commit is contained in:
kleines Filmröllchen 2022-08-30 12:49:08 +02:00 • committed by Linus Groh
parent 38bb189772
commit cb0b82ec46
7 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibGUI/AboutDialog.h
View file

@ -17,16 +17,16 @@ class AboutDialog final : public Dialog {
public:
virtual ~AboutDialog() override = default;
static void show(StringView name, Gfx::Bitmap const* icon = nullptr, Window* parent_window = nullptr, Gfx::Bitmap const* window_icon = nullptr, StringView version = Core::Version::SERENITY_VERSION)
static void show(StringView name, StringView version, Gfx::Bitmap const* icon = nullptr, Window* parent_window = nullptr, Gfx::Bitmap const* window_icon = nullptr)
{
auto dialog = AboutDialog::construct(name, icon, parent_window, version);
auto dialog = AboutDialog::construct(name, version, icon, parent_window);
if (window_icon)
dialog->set_icon(window_icon);
dialog->exec();
}
private:
AboutDialog(StringView name, Gfx::Bitmap const* icon = nullptr, Window* parent_window = nullptr, StringView version = Core::Version::SERENITY_VERSION);
AboutDialog(StringView name, StringView version, Gfx::Bitmap const* icon = nullptr, Window* parent_window = nullptr);
String m_name;
RefPtr<Gfx::Bitmap> m_icon;