RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-19 00:25:07 +00:00
Code Issues Activity Actions

Userland+LibCore: Remove legacy SERENITY_VERSION from Core::Version

Browse source 
This was being used as a default version argument in a couple of APIs,
so those need to change signature and the caller always needs to provide
a version.
This commit is contained in:
kleines Filmröllchen 2022-08-30 12:49:08 +02:00 • committed by Linus Groh
parent 38bb189772
commit cb0b82ec46
7 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGUI/CommonActions.cpp
View file

@ -7,6 +7,7 @@
#include <AK/Function.h>
#include <AK/String.h>
#include <AK/WeakPtr.h>
#include <LibCore/Version.h>
#include <LibGUI/AboutDialog.h>
#include <LibGUI/Action.h>
#include <LibGUI/Icon.h>
@ -19,7 +20,7 @@ NonnullRefPtr<Action> make_about_action(String const& app_name, Icon const& app_
{
auto weak_parent = AK::make_weak_ptr_if_nonnull<Window>(parent);
auto action = Action::create(String::formatted("&About {}", app_name), app_icon.bitmap_for_size(16), [=](auto&) {
AboutDialog::show(app_name, app_icon.bitmap_for_size(32), weak_parent.ptr());
AboutDialog::show(app_name, Core::Version::read_long_version_string(), app_icon.bitmap_for_size(32), weak_parent.ptr());
});
action->set_status_tip("Show application about box");
return action;