RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:17:36 +00:00
Code Issues Activity Actions

WindowServer+Magnifier: Make Magnifier buttery smooth :^)

Browse source 
This patch moves the magnifier rect computation over to the server side
to ensure that the mouse cursor position and the screen image never get
out of sync.
This commit is contained in:
Andreas Kling 2021-06-07 10:20:50 +02:00
parent 0ea1fd2d54
commit cb295ab644
5 changed files with 18 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Applications/Magnifier/MagnifierWidget.cpp
View file

@ -39,13 +39,8 @@ void MagnifierWidget::set_scale_factor(int scale_factor)
void MagnifierWidget::sync()
{
m_mouse_position = GUI::WindowServerConnection::the().get_global_cursor_position();
m_desktop_display_scale = GUI::WindowServerConnection::the().get_desktop_display_scale();
// Grab and paint our screenshot.
Gfx::IntSize region_size { size().width() / m_scale_factor, size().height() / m_scale_factor };
Gfx::Rect region { (m_mouse_position.x() * m_desktop_display_scale) - (region_size.width() / 2), (m_mouse_position.y() * m_desktop_display_scale) - (region_size.height() / 2), region_size.width(), region_size.height() };
m_grabbed_bitmap = GUI::WindowServerConnection::the().get_screen_bitmap(region).bitmap();
Gfx::IntSize grab_size { size().width() / m_scale_factor, size().height() / m_scale_factor };
m_grabbed_bitmap = GUI::WindowServerConnection::the().get_screen_bitmap_around_cursor(grab_size).bitmap();
update();
}