RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:27:35 +00:00
Code Issues Activity Actions

Kernel: Remove "allow CPU caching" flag on VMObject

Browse source 
This wasn't really thought-through, I was just trying anything to see
if it would make WindowServer faster. This doesn't seem to make much of
a difference either way, so let's just not do it for now.

It's easy to bring back if we think we need it in the future.
This commit is contained in:
Andreas Kling 2019-08-07 16:34:00 +02:00
parent 3364da388f
commit cb2d572a14
3 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/VM/MemoryManager.cpp
View file

@ -675,8 +675,6 @@ void MemoryManager::remap_region_page(Region& region, unsigned page_index_in_reg
pte.set_writable(false); pte.set_writable(false);
else else
pte.set_writable(region.is_writable()); pte.set_writable(region.is_writable());
pte.set_cache_disabled(!region.vmo().m_allow_cpu_caching);
pte.set_write_through(!region.vmo().m_allow_cpu_caching);
pte.set_user_allowed(region.is_user_accessible()); pte.set_user_allowed(region.is_user_accessible());
region.page_directory()->flush(page_vaddr); region.page_directory()->flush(page_vaddr);
#ifdef MM_DEBUG #ifdef MM_DEBUG
@ -711,8 +709,6 @@ void MemoryManager::map_region_at_address(PageDirectory& page_directory, Region&
pte.set_writable(false); pte.set_writable(false);
else else
pte.set_writable(region.is_writable()); pte.set_writable(region.is_writable());
pte.set_cache_disabled(!region.vmo().m_allow_cpu_caching);
pte.set_write_through(!region.vmo().m_allow_cpu_caching);
} else { } else {
pte.set_physical_page_base(0); pte.set_physical_page_base(0);
pte.set_present(false); pte.set_present(false);

4
Kernel/VM/VMObject.cpp
View file

@ -22,9 +22,7 @@ NonnullRefPtr<VMObject> VMObject::create_anonymous(size_t size)
NonnullRefPtr<VMObject> VMObject::create_for_physical_range(PhysicalAddress paddr, size_t size) NonnullRefPtr<VMObject> VMObject::create_for_physical_range(PhysicalAddress paddr, size_t size)
{ {
size = ceil_div(size, PAGE_SIZE) * PAGE_SIZE; size = ceil_div(size, PAGE_SIZE) * PAGE_SIZE;
auto vmo = adopt(*new VMObject(paddr, size)); return adopt(*new VMObject(paddr, size));
vmo->m_allow_cpu_caching = false;
return vmo;
} }
NonnullRefPtr<VMObject> VMObject::clone() NonnullRefPtr<VMObject> VMObject::clone()

1
Kernel/VM/VMObject.h
View file

@ -48,7 +48,6 @@ private:
template<typename Callback> template<typename Callback>
void for_each_region(Callback); void for_each_region(Callback);
bool m_allow_cpu_caching { true };
off_t m_inode_offset { 0 }; off_t m_inode_offset { 0 };
size_t m_size { 0 }; size_t m_size { 0 };
RefPtr<Inode> m_inode; RefPtr<Inode> m_inode;