RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 15:34:58 +00:00
Code Issues Activity Actions

HackStudio: Add icons for "step in" and "step out"

Browse source
This commit is contained in:
Itamar 2020-08-21 11:51:32 +03:00 • committed by Andreas Kling
parent ebab512c03
commit cb432ffe8c
6 changed files with 21 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

2
DevTools/HackStudio/Debugger/Debugger.cpp
View file

@ -78,7 +78,7 @@ void Debugger::on_breakpoint_change(const String& file, size_t line, BreakpointC
auto address = session->debug_info().get_instruction_from_source(position.file_path, position.line_number);
if (!address.has_value()) {
dbg() << "Warning: couldn't get instruction address from source";
// TODO: Currently, the GUI will indicate that a breakpoint was inserted/remove at this line,
// TODO: Currently, the GUI will indicate that a breakpoint was inserted/removed at this line,
// regardless of whether we actually succeeded to insert it. (For example a breakpoint on a comment, or an include statemanet).
// We should indicate failure via a return value from this function, and not update the breakpoint GUI if we fail.
return;