RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:57:34 +00:00
Code Issues Activity Actions

AK: Percent encode URL fragments when parsed

Browse source 
This fixes URL fragments containing characters in the fragment encoding
set that were not being correctly percent encoded.
This commit is contained in:
Shannon Booth 2023-08-14 16:25:21 +12:00 • committed by Andrew Kaster
parent 4eab37f391
commit cb4c279e90
3 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
AK/URLParser.cpp
View file

@ -1635,10 +1635,11 @@ URL URLParser::basic_parse(StringView raw_input, Optional<URL> const& base_url,
if (code_point == '%' && !remaining_starts_with_two_ascii_hex_digits())
report_validation_error();
// FIXME: 3. UTF-8 percent-encode c using the fragment percent-encode set and append the result to url’s fragment.
// 3. UTF-8 percent-encode c using the fragment percent-encode set and append the result to url’s fragment.
// NOTE: The percent-encode is done on EOF on the entire buffer.
buffer.append_code_point(code_point);
} else {
url->m_fragment = buffer.to_string().release_value_but_fixme_should_propagate_errors();
url->m_fragment = String::from_deprecated_string(percent_encode_after_encoding(buffer.string_view(), URL::PercentEncodeSet::Fragment)).release_value_but_fixme_should_propagate_errors();
buffer.clear();
}
break;