RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:47:37 +00:00
Code Issues Activity Actions

LibGUI: Fix off-by-one error in Lexer tokens

Browse source 
This changes the INI and GML lexers to conform to the now-fixed
rendering of syntax highlighting spans in GUI::TextEditor.

The other user of GMLToken::m_end, GMLAutocompleteProvider, has been
modified to take into account that end position columns have been
incremented by one.
This commit is contained in:
Max Wipfli 2021-06-04 00:05:33 +02:00 • committed by Ali Mohammad Pur
parent e7b5dbe1ac
commit cb5a50d3f7
5 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGUI/GMLLexer.cpp
View file

@ -26,7 +26,6 @@ char GMLLexer::consume()
{
VERIFY(m_index < m_input.length());
char ch = m_input[m_index++];
m_previous_position = m_position;
if (ch == '\n') {
m_position.line++;
m_position.column = 0;
@ -68,7 +67,7 @@ Vector<GMLToken> GMLLexer::lex()
token.m_view = m_input.substring_view(token_start_index, m_index - token_start_index);
token.m_type = type;
token.m_start = token_start_position;
token.m_end = m_previous_position;
token.m_end = m_position;
tokens.append(token);
};