diff --git a/Userland/Libraries/LibCoredump/Backtrace.cpp b/Userland/Libraries/LibCoredump/Backtrace.cpp index 6c77903e45..fa4515f8f7 100644 --- a/Userland/Libraries/LibCoredump/Backtrace.cpp +++ b/Userland/Libraries/LibCoredump/Backtrace.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Linus Groh + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -91,10 +92,6 @@ Backtrace::Backtrace(const Reader& coredump, const ELF::Core::ThreadInfo& thread } } -Backtrace::~Backtrace() -{ -} - void Backtrace::add_entry(const Reader& coredump, FlatPtr ip) { auto ip_region = coredump.region_containing(ip); diff --git a/Userland/Libraries/LibCoredump/Backtrace.h b/Userland/Libraries/LibCoredump/Backtrace.h index bb2db6dcdd..d06bad1167 100644 --- a/Userland/Libraries/LibCoredump/Backtrace.h +++ b/Userland/Libraries/LibCoredump/Backtrace.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Linus Groh + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -38,7 +39,7 @@ public: }; Backtrace(const Reader&, const ELF::Core::ThreadInfo&, Function on_progress = {}); - ~Backtrace(); + ~Backtrace() = default; ELF::Core::ThreadInfo const& thread_info() const { return m_thread_info; } Vector const& entries() const { return m_entries; } diff --git a/Userland/Libraries/LibCoredump/Reader.cpp b/Userland/Libraries/LibCoredump/Reader.cpp index 38c5d3ead3..445acd353c 100644 --- a/Userland/Libraries/LibCoredump/Reader.cpp +++ b/Userland/Libraries/LibCoredump/Reader.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -76,10 +77,6 @@ Optional Reader::decompress_coredump(ReadonlyBytes raw_coredump) return bytebuffer.release_value(); } -Reader::~Reader() -{ -} - Reader::NotesEntryIterator::NotesEntryIterator(const u8* notes_data) : m_current(bit_cast(notes_data)) , start(notes_data) diff --git a/Userland/Libraries/LibCoredump/Reader.h b/Userland/Libraries/LibCoredump/Reader.h index 7d7f658d0d..5fef5b1a88 100644 --- a/Userland/Libraries/LibCoredump/Reader.h +++ b/Userland/Libraries/LibCoredump/Reader.h @@ -40,7 +40,7 @@ class Reader { public: static OwnPtr create(StringView); - ~Reader(); + ~Reader() = default; template void for_each_memory_region_info(Func func) const;