From cbe506020bfab2f01539d7b2ce60379e4ae9986b Mon Sep 17 00:00:00 2001 From: Matthew Olsson Date: Thu, 28 May 2020 07:11:01 -0700 Subject: [PATCH] LibJS: Strict mode assignment to 'eval' & 'arguments' is a syntax error --- Libraries/LibJS/Parser.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Libraries/LibJS/Parser.cpp b/Libraries/LibJS/Parser.cpp index 2e72f07717..97b46d8db9 100644 --- a/Libraries/LibJS/Parser.cpp +++ b/Libraries/LibJS/Parser.cpp @@ -816,6 +816,16 @@ NonnullRefPtr Parser::parse_secondary_expression(NonnullRefPtr(); } + if (m_parser_state.m_strict_mode && lhs->is_identifier()) { + auto name = static_cast(*lhs).string(); + if (name == "eval" || name == "arguments") { + syntax_error( + String::format("'%s' cannot be assigned to in strict mode code", name.characters()), + m_parser_state.m_current_token.line_number(), + m_parser_state.m_current_token.line_column() + ); + } + } return create_ast_node(AssignmentOp::Assignment, move(lhs), parse_expression(min_precedence, associativity)); case TokenType::Period: consume();