RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:48:11 +00:00
Code Issues Activity Actions

LibThread: Fix destroying background actions

Browse source 
In the old model, before bc319d9e88, the parent
(the background thread) would delete us when it exits (i.e. never), so we had to
keep track of our own refcount in order to destroy ourselves when we're done.

With bc319d9e88, the parent keeps additional
reference to us, so:
* There should be no need to explicitly ref() ourselves
* The unref() would not get rid of the last reference to us anymore

The latter is why all the BackgroundAction's were getting leaked. Fix this by
simply unparenting ourselves from the background thread when we're done.
This commit is contained in:
Sergey Bugaev 2020-02-25 12:05:25 +03:00 • committed by Andreas Kling
parent ab9a0780e3
commit cbf2881bf7
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibThread/BackgroundAction.h
View file

@ -75,17 +75,17 @@ private:
{
LOCKER(all_actions().lock());
this->ref();
all_actions().resource().enqueue([this] {
m_result = m_action();
if (m_on_complete) {
Core::EventLoop::current().post_event(*this, make<Core::DeferredInvocationEvent>([this](auto&) {
m_on_complete(m_result.release_value());
this->unref();
this->remove_from_parent();
}));
Core::EventLoop::wake();
} else
this->unref();
} else {
this->remove_from_parent();
}
});
}