RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-16 21:47:35 +00:00
Code Issues Activity Actions

Kernel: Remove pledge syscall from the big lock

Browse source 
This already does all its dangerous work inside
`with_mutable_protected_data()`.
This commit is contained in:
Sam Atkins 2023-02-03 17:49:06 +00:00 • committed by Andreas Kling
parent ce78394ae8
commit cc558d95f0
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -133,7 +133,7 @@ enum class NeedsBigProcessLock {
S(perf_event, NeedsBigProcessLock::Yes) \ S(perf_event, NeedsBigProcessLock::Yes) \
S(perf_register_string, NeedsBigProcessLock::Yes) \ S(perf_register_string, NeedsBigProcessLock::Yes) \
S(pipe, NeedsBigProcessLock::No) \ S(pipe, NeedsBigProcessLock::No) \
S(pledge, NeedsBigProcessLock::Yes) \ S(pledge, NeedsBigProcessLock::No) \
S(poll, NeedsBigProcessLock::Yes) \ S(poll, NeedsBigProcessLock::Yes) \
S(posix_fallocate, NeedsBigProcessLock::No) \ S(posix_fallocate, NeedsBigProcessLock::No) \
S(prctl, NeedsBigProcessLock::Yes) \ S(prctl, NeedsBigProcessLock::Yes) \

2
Kernel/Syscalls/pledge.cpp
View file

@ -11,7 +11,7 @@ namespace Kernel {
ErrorOr<FlatPtr> Process::sys$pledge(Userspace<Syscall::SC_pledge_params const*> user_params) ErrorOr<FlatPtr> Process::sys$pledge(Userspace<Syscall::SC_pledge_params const*> user_params)
{ {
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); VERIFY_NO_PROCESS_BIG_LOCK(this);
auto params = TRY(copy_typed_from_user(user_params)); auto params = TRY(copy_typed_from_user(user_params));
if (params.promises.length > 1024 || params.execpromises.length > 1024) if (params.promises.length > 1024 || params.execpromises.length > 1024)