mirror of
https://github.com/RGBCube/serenity
synced 2025-05-31 15:28:11 +00:00
LibJS: Split out NumberToBigInt from the BigInt constructor
This is supposed to be its own AO, but since it was only used in one place, we inlined it. Now that it's also being used in the Temporal proposal (Date.prototype.toTemporalInstant() specifically), it makes sense to have it as a standalone function. A small difference is that we now construct the SignedBigInteger without casting to i32 but instead take the (known to be integral) double and cast it to i64. Not perfect, but slightly better. Also clean up the BigInt constructor a bit while we're here and sprinkle some spec comments.
This commit is contained in:
parent
3e8574a9a8
commit
cc64efac44
3 changed files with 37 additions and 17 deletions
|
@ -1,5 +1,5 @@
|
|||
/*
|
||||
* Copyright (c) 2020, Linus Groh <linusg@serenityos.org>
|
||||
* Copyright (c) 2020-2021, Linus Groh <linusg@serenityos.org>
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
@ -7,6 +7,7 @@
|
|||
#include <LibCrypto/BigInt/SignedBigInteger.h>
|
||||
#include <LibJS/Heap/Heap.h>
|
||||
#include <LibJS/Runtime/BigInt.h>
|
||||
#include <LibJS/Runtime/GlobalObject.h>
|
||||
|
||||
namespace JS {
|
||||
|
||||
|
@ -25,4 +26,20 @@ BigInt* js_bigint(Heap& heap, Crypto::SignedBigInteger big_integer)
|
|||
return heap.allocate_without_global_object<BigInt>(move(big_integer));
|
||||
}
|
||||
|
||||
// 21.2.1.1.1 NumberToBigInt ( number ), https://tc39.es/ecma262/#sec-numbertobigint
|
||||
BigInt* number_to_bigint(GlobalObject& global_object, Value number)
|
||||
{
|
||||
VERIFY(number.is_number());
|
||||
auto& vm = global_object.vm();
|
||||
|
||||
// 1. If IsIntegralNumber(number) is false, throw a RangeError exception.
|
||||
if (!number.is_integral_number()) {
|
||||
vm.throw_exception<RangeError>(global_object, ErrorType::BigIntIntArgument);
|
||||
return {};
|
||||
}
|
||||
|
||||
// 2. Return the BigInt value that represents ℝ(number).
|
||||
return js_bigint(vm.heap(), Crypto::SignedBigInteger::create_from((i64)number.as_double()));
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue