RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:27:45 +00:00
Code Issues Activity Actions

LibWeb: Treat grid items with z-index != auto as positioned elements

Browse source
This commit is contained in:
Aliaksandr Kalenik 2023-08-21 17:07:53 +02:00 • committed by Andreas Kling
parent 95a8dec373
commit cca779e7f6
5 changed files with 33 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Painting/Paintable.cpp
View file

@ -27,6 +27,16 @@ void Paintable::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_containing_block.value());
}
bool Paintable::is_positioned() const
{
if (layout_node().is_grid_item() && computed_values().z_index().has_value()) {
// https://www.w3.org/TR/css-grid-2/#z-order
// grid items with z_index should behave as if position were "relative"
return true;
}
return computed_values().position() != CSS::Position::Static;
}
void Paintable::set_dom_node(JS::GCPtr<DOM::Node> dom_node)
{
m_dom_node = dom_node;

2
Userland/Libraries/LibWeb/Painting/Paintable.h
View file

@ -56,7 +56,7 @@ class Paintable
public:
virtual ~Paintable() = default;
[[nodiscard]] bool is_positioned() const { return layout_node().is_positioned(); }
[[nodiscard]] bool is_positioned() const;
[[nodiscard]] bool is_fixed_position() const { return layout_node().is_fixed_position(); }
[[nodiscard]] bool is_absolutely_positioned() const { return layout_node().is_absolutely_positioned(); }
[[nodiscard]] bool is_floating() const { return layout_node().is_floating(); }