RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:18:12 +00:00
Code Issues Activity Actions

LibGUI+Applications: Use String in make_about_action()

Browse source
This commit is contained in:
Tim Ledbetter 2023-09-13 20:34:46 +01:00 • committed by Andreas Kling
parent e7a5a2e146
commit ccab5ddf9b
53 changed files with 60 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/CommonActions.cpp
View file

@ -17,12 +17,12 @@ namespace GUI {
namespace CommonActions {
NonnullRefPtr<Action> make_about_action(DeprecatedString const& app_name, Icon const& app_icon, Window* parent)
NonnullRefPtr<Action> make_about_action(String const& app_name, Icon const& app_icon, Window* parent)
{
auto weak_parent = AK::make_weak_ptr_if_nonnull<Window>(parent);
auto action = Action::create(DeprecatedString::formatted("&About {}", app_name), app_icon.bitmap_for_size(16), [=](auto&) {
AboutDialog::show(
String::from_deprecated_string(app_name).release_value_but_fixme_should_propagate_errors(),
app_name,
Core::Version::read_long_version_string().release_value_but_fixme_should_propagate_errors(),
app_icon.bitmap_for_size(32),
weak_parent);