RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:38:10 +00:00
Code Issues Activity Actions

Kernel: Harden Socket::pseudo_path(..) implementations against OOM

Browse source 
Use the try variants of AK::StringBuilder append APIs to harden these
functions against OOM.
This commit is contained in:
Brian Gianforcaro 2022-01-09 00:59:12 -08:00 • committed by Andreas Kling
parent ea66750640
commit ccbc3f8975
2 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Kernel/Net/IPv4Socket.cpp
View file

@ -474,24 +474,24 @@ ErrorOr<NonnullOwnPtr<KString>> IPv4Socket::pseudo_path(const OpenFileDescriptio
return KString::try_create("socket"sv);
StringBuilder builder;
builder.append("socket:");
TRY(builder.try_append("socket:"));
builder.appendff("{}:{}", m_local_address.to_string(), m_local_port);
TRY(builder.try_appendff("{}:{}", m_local_address.to_string(), m_local_port));
if (m_role == Role::Accepted || m_role == Role::Connected)
builder.appendff(" / {}:{}", m_peer_address.to_string(), m_peer_port);
TRY(builder.try_appendff(" / {}:{}", m_peer_address.to_string(), m_peer_port));
switch (m_role) {
case Role::Listener:
builder.append(" (listening)");
TRY(builder.try_append(" (listening)"));
break;
case Role::Accepted:
builder.append(" (accepted)");
TRY(builder.try_append(" (accepted)"));
break;
case Role::Connected:
builder.append(" (connected)");
TRY(builder.try_append(" (connected)"));
break;
case Role::Connecting:
builder.append(" (connecting)");
TRY(builder.try_append(" (connecting)"));
break;
default:
VERIFY_NOT_REACHED();