RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 07:55:07 +00:00
Code Issues Activity Actions

LibJS: Use FlyString for identifiers

Browse source 
This makes variable and property lookups a lot faster since comparing
two FlyStrings is O(1).
This commit is contained in:
Andreas Kling 2020-03-22 11:07:55 +01:00
parent 4f72f6b886
commit cccbe43056
19 changed files with 67 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibJS/Interpreter.cpp
View file

@ -65,7 +65,7 @@ Value Interpreter::run(const ScopeNode& scope_node, Vector<Argument> arguments,
void Interpreter::enter_scope(const ScopeNode& scope_node, Vector<Argument> arguments, ScopeType scope_type)
{
HashMap<String, Variable> scope_variables_with_declaration_type;
HashMap<FlyString, Variable> scope_variables_with_declaration_type;
for (auto& argument : arguments) {
scope_variables_with_declaration_type.set(argument.name, { argument.value, DeclarationType::Var });
}
@ -83,7 +83,7 @@ void Interpreter::do_return()
dbg() << "FIXME: Implement Interpreter::do_return()";
}
void Interpreter::declare_variable(String name, DeclarationType declaration_type)
void Interpreter::declare_variable(const FlyString& name, DeclarationType declaration_type)
{
switch (declaration_type) {
case DeclarationType::Var:
@ -110,7 +110,7 @@ void Interpreter::declare_variable(String name, DeclarationType declaration_type
}
}
void Interpreter::set_variable(String name, Value value, bool first_assignment)
void Interpreter::set_variable(const FlyString& name, Value value, bool first_assignment)
{
for (ssize_t i = m_scope_stack.size() - 1; i >= 0; --i) {
auto& scope = m_scope_stack.at(i);
@ -128,7 +128,7 @@ void Interpreter::set_variable(String name, Value value, bool first_assignment)
global_object().put(move(name), move(value));
}
Value Interpreter::get_variable(const String& name)
Value Interpreter::get_variable(const FlyString& name)
{
for (ssize_t i = m_scope_stack.size() - 1; i >= 0; --i) {
auto& scope = m_scope_stack.at(i);