RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:57:45 +00:00
Code Issues Activity Actions

LibJS: Use FlyString for identifiers

Browse source 
This makes variable and property lookups a lot faster since comparing
two FlyStrings is O(1).
This commit is contained in:
Andreas Kling 2020-03-22 11:07:55 +01:00
parent 4f72f6b886
commit cccbe43056
19 changed files with 67 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibJS/Interpreter.h
View file

@ -28,6 +28,7 @@
#include <AK/HashMap.h>
#include <AK/String.h>
#include <AK/FlyString.h>
#include <AK/Vector.h>
#include <LibJS/Forward.h>
#include <LibJS/Heap/Heap.h>
@ -48,7 +49,7 @@ struct Variable {
struct ScopeFrame {
ScopeType type;
NonnullRefPtr<ScopeNode> scope_node;
HashMap<String, Variable> variables;
HashMap<FlyString, Variable> variables;
};
struct CallFrame {
@ -57,7 +58,7 @@ struct CallFrame {
};
struct Argument {
String name;
FlyString name;
Value value;
};
@ -75,9 +76,9 @@ public:
void do_return();
Value get_variable(const String& name);
void set_variable(String name, Value, bool first_assignment = false);
void declare_variable(String name, DeclarationType);
Value get_variable(const FlyString& name);
void set_variable(const FlyString& name, Value, bool first_assignment = false);
void declare_variable(const FlyString& name, DeclarationType);
void gather_roots(Badge<Heap>, HashTable<Cell*>&);
@ -86,7 +87,11 @@ public:
Value call(Function*, Value this_value, const Vector<Value>& arguments);
CallFrame& push_call_frame() { m_call_stack.append({ js_undefined(), {} }); return m_call_stack.last(); }
CallFrame& push_call_frame()
{
m_call_stack.append({ js_undefined(), {} });
return m_call_stack.last();
}
void pop_call_frame() { m_call_stack.take_last(); }
Value this_value() const
{