mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 20:47:45 +00:00
Everywhere: Add deprecated_ prefix to JsonValue::to_byte_string
`JsonValue::to_byte_string` has peculiar type-erasure semantics which is not usually intended. Unfortunately, it also has a very stereotypical name which does not warn about unexpected behavior. So let's prefix it with `deprecated_` to make new code use `as_string` if it just wants to get string value or `serialized<StringBuilder>` if it needs to do proper serialization.
This commit is contained in:
parent
4ed5287792
commit
ccd701809f
20 changed files with 46 additions and 50 deletions
|
@ -77,7 +77,7 @@ enum class ValueID;
|
|||
enum_generator.appendln("enum class @name:titlecase@ : @enum_type@ {");
|
||||
|
||||
for (auto& member : members.values()) {
|
||||
auto member_name = member.to_byte_string();
|
||||
auto member_name = member.as_string();
|
||||
// Don't include aliases in the enum.
|
||||
if (member_name.contains('='))
|
||||
continue;
|
||||
|
@ -126,7 +126,7 @@ Optional<@name:titlecase@> value_id_to_@name:snakecase@(ValueID value_id)
|
|||
|
||||
for (auto& member : members.values()) {
|
||||
auto member_generator = enum_generator.fork();
|
||||
auto member_name = member.to_byte_string();
|
||||
auto member_name = member.as_string();
|
||||
if (member_name.contains('=')) {
|
||||
auto parts = member_name.split_view('=');
|
||||
member_generator.set("valueid:titlecase", title_casify(parts[0]));
|
||||
|
@ -154,7 +154,7 @@ ValueID to_value_id(@name:titlecase@ @name:snakecase@_value)
|
|||
|
||||
for (auto& member : members.values()) {
|
||||
auto member_generator = enum_generator.fork();
|
||||
auto member_name = member.to_byte_string();
|
||||
auto member_name = member.as_string();
|
||||
if (member_name.contains('='))
|
||||
continue;
|
||||
member_generator.set("member:titlecase", title_casify(member_name));
|
||||
|
@ -178,7 +178,7 @@ StringView to_string(@name:titlecase@ value)
|
|||
|
||||
for (auto& member : members.values()) {
|
||||
auto member_generator = enum_generator.fork();
|
||||
auto member_name = member.to_byte_string();
|
||||
auto member_name = member.as_string();
|
||||
if (member_name.contains('='))
|
||||
continue;
|
||||
member_generator.set("member:css", member_name);
|
||||
|
|
|
@ -73,7 +73,7 @@ void replace_logical_aliases(JsonObject& properties)
|
|||
if (logical_alias_for.has_value()) {
|
||||
auto const& aliased_properties = logical_alias_for.value();
|
||||
for (auto const& aliased_property : aliased_properties.values()) {
|
||||
logical_aliases.set(name, aliased_property.to_byte_string());
|
||||
logical_aliases.set(name, aliased_property.as_string());
|
||||
}
|
||||
}
|
||||
});
|
||||
|
@ -768,7 +768,7 @@ size_t property_maximum_value_count(PropertyID property_id)
|
|||
VERIFY(max_values.has_value() && max_values->is_number() && !max_values->is_double());
|
||||
auto property_generator = generator.fork();
|
||||
property_generator.set("name:titlecase", title_casify(name));
|
||||
property_generator.set("max_values", max_values->to_byte_string());
|
||||
property_generator.set("max_values", max_values->template serialized<StringBuilder>());
|
||||
property_generator.append(R"~~~(
|
||||
case PropertyID::@name:titlecase@:
|
||||
return @max_values@;
|
||||
|
@ -834,7 +834,7 @@ Vector<PropertyID> longhands_for_shorthand(PropertyID property_id)
|
|||
first = false;
|
||||
else
|
||||
builder.append(", "sv);
|
||||
builder.appendff("PropertyID::{}", title_casify(longhand.to_byte_string()));
|
||||
builder.appendff("PropertyID::{}", title_casify(longhand.as_string()));
|
||||
return IterationDecision::Continue;
|
||||
});
|
||||
property_generator.set("longhands", builder.to_byte_string());
|
||||
|
|
|
@ -195,7 +195,7 @@ TransformFunctionMetadata transform_function_metadata(TransformFunction transfor
|
|||
member_generator.append(first ? " "sv : ", "sv);
|
||||
first = false;
|
||||
|
||||
member_generator.append(MUST(String::formatted("{{ TransformFunctionParameterType::{}, {}}}", parameter_type, value.as_object().get("required"sv)->to_byte_string())));
|
||||
member_generator.append(MUST(String::formatted("{{ TransformFunctionParameterType::{}, {}}}", parameter_type, value.as_object().get("required"sv)->as_bool())));
|
||||
});
|
||||
|
||||
member_generator.append(R"~~~( }
|
||||
|
|
|
@ -57,7 +57,7 @@ enum class ValueID {
|
|||
|
||||
identifier_data.for_each([&](auto& name) {
|
||||
auto member_generator = generator.fork();
|
||||
member_generator.set("name:titlecase", title_casify(name.to_byte_string()));
|
||||
member_generator.set("name:titlecase", title_casify(name.as_string()));
|
||||
|
||||
member_generator.append(R"~~~(
|
||||
@name:titlecase@,
|
||||
|
@ -105,8 +105,8 @@ HashMap<StringView, ValueID, AK::CaseInsensitiveASCIIStringViewTraits> g_stringv
|
|||
|
||||
identifier_data.for_each([&](auto& name) {
|
||||
auto member_generator = generator.fork();
|
||||
member_generator.set("name", name.to_byte_string());
|
||||
member_generator.set("name:titlecase", title_casify(name.to_byte_string()));
|
||||
member_generator.set("name", name.as_string());
|
||||
member_generator.set("name:titlecase", title_casify(name.as_string()));
|
||||
member_generator.append(R"~~~(
|
||||
{"@name@"sv, ValueID::@name:titlecase@},
|
||||
)~~~");
|
||||
|
@ -126,8 +126,8 @@ StringView string_from_value_id(ValueID value_id) {
|
|||
|
||||
identifier_data.for_each([&](auto& name) {
|
||||
auto member_generator = generator.fork();
|
||||
member_generator.set("name", name.to_byte_string());
|
||||
member_generator.set("name:titlecase", title_casify(name.to_byte_string()));
|
||||
member_generator.set("name", name.as_string());
|
||||
member_generator.set("name:titlecase", title_casify(name.as_string()));
|
||||
member_generator.append(R"~~~(
|
||||
case ValueID::@name:titlecase@:
|
||||
return "@name@"sv;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue