mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 05:07:35 +00:00
Everywhere: Add deprecated_ prefix to JsonValue::to_byte_string
`JsonValue::to_byte_string` has peculiar type-erasure semantics which is not usually intended. Unfortunately, it also has a very stereotypical name which does not warn about unexpected behavior. So let's prefix it with `deprecated_` to make new code use `as_string` if it just wants to get string value or `serialized<StringBuilder>` if it needs to do proper serialization.
This commit is contained in:
parent
4ed5287792
commit
ccd701809f
20 changed files with 46 additions and 50 deletions
|
@ -133,7 +133,8 @@ HashMap<ByteString, ByteString> Presentation::parse_metadata(JsonObject const& m
|
|||
HashMap<ByteString, ByteString> metadata;
|
||||
|
||||
metadata_object.for_each_member([&](auto const& key, auto const& value) {
|
||||
metadata.set(key, value.to_byte_string());
|
||||
// FIXME: Do not serialize values here just to convert them back to proper types later.
|
||||
metadata.set(key, value.deprecated_to_byte_string());
|
||||
});
|
||||
|
||||
return metadata;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue