mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 02:27:35 +00:00
Everywhere: Add deprecated_ prefix to JsonValue::to_byte_string
`JsonValue::to_byte_string` has peculiar type-erasure semantics which is not usually intended. Unfortunately, it also has a very stereotypical name which does not warn about unexpected behavior. So let's prefix it with `deprecated_` to make new code use `as_string` if it just wants to get string value or `serialized<StringBuilder>` if it needs to do proper serialization.
This commit is contained in:
parent
4ed5287792
commit
ccd701809f
20 changed files with 46 additions and 50 deletions
|
@ -166,7 +166,7 @@ ByteString HelpWindow::render(StringView key)
|
|||
markdown_builder.append("No required arguments.\n"sv);
|
||||
|
||||
for (size_t i = 0; i < argc; ++i)
|
||||
markdown_builder.appendff("- `{}`\n", argnames.at(i).to_byte_string());
|
||||
markdown_builder.appendff("- `{}`\n", argnames.at(i).as_string());
|
||||
|
||||
if (argc > 0)
|
||||
markdown_builder.append("\n"sv);
|
||||
|
@ -175,7 +175,7 @@ ByteString HelpWindow::render(StringView key)
|
|||
auto opt_count = argnames.size() - argc;
|
||||
markdown_builder.appendff("{} optional argument(s):\n", opt_count);
|
||||
for (size_t i = argc; i < (size_t)argnames.size(); ++i)
|
||||
markdown_builder.appendff("- `{}`\n", argnames.at(i).to_byte_string());
|
||||
markdown_builder.appendff("- `{}`\n", argnames.at(i).as_string());
|
||||
markdown_builder.append("\n"sv);
|
||||
}
|
||||
|
||||
|
@ -188,8 +188,8 @@ ByteString HelpWindow::render(StringView key)
|
|||
VERIFY(examples.has_value());
|
||||
markdown_builder.append("# EXAMPLES\n"sv);
|
||||
examples->for_each_member([&](auto& text, auto& description_value) {
|
||||
dbgln("```js\n{}\n```\n\n- {}\n", text, description_value.to_byte_string());
|
||||
markdown_builder.appendff("```js\n{}\n```\n\n- {}\n", text, description_value.to_byte_string());
|
||||
dbgln("```js\n{}\n```\n\n- {}\n", text, description_value.as_string());
|
||||
markdown_builder.appendff("```js\n{}\n```\n\n- {}\n", text, description_value.as_string());
|
||||
});
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue