RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 12:25:06 +00:00
Code Issues Activity Actions

LibWeb: Insert newlines at <br> and block boundaries in copied text :^)

Browse source 
To make the plain text we copy out from LibWeb look at least somewhat
like its original form, let's insert newlines at <br> elements and when
we exit a block-level element.

This is far from perfect, but seems to work pretty okay.
This commit is contained in:
Andreas Kling 2020-07-03 21:02:55 +02:00
parent f7ef6c65b4
commit ccdaa1bea9
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/PageView.cpp
View file

@ -46,6 +46,7 @@
#include <LibWeb/Frame/EventHandler.h> #include <LibWeb/Frame/EventHandler.h>
#include <LibWeb/Frame/Frame.h> #include <LibWeb/Frame/Frame.h>
#include <LibWeb/Layout/LayoutDocument.h> #include <LibWeb/Layout/LayoutDocument.h>
#include <LibWeb/Layout/LayoutBreak.h>
#include <LibWeb/Layout/LayoutNode.h> #include <LibWeb/Layout/LayoutNode.h>
#include <LibWeb/Layout/LayoutText.h> #include <LibWeb/Layout/LayoutText.h>
#include <LibWeb/Loader/ResourceLoader.h> #include <LibWeb/Loader/ResourceLoader.h>
@ -141,6 +142,9 @@ String PageView::selected_text() const
while (layout_node && layout_node != selection.end().layout_node) { while (layout_node && layout_node != selection.end().layout_node) {
if (is<LayoutText>(*layout_node)) if (is<LayoutText>(*layout_node))
builder.append(to<LayoutText>(*layout_node).text_for_rendering()); builder.append(to<LayoutText>(*layout_node).text_for_rendering());
else if (is<LayoutBreak>(*layout_node) || is<LayoutBlock>(*layout_node))
builder.append('\n');
layout_node = layout_node->next_in_pre_order(); layout_node = layout_node->next_in_pre_order();
} }