RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Derive box baseline from last child *with line boxes*

Browse source 
Before this change, we always derived a box's baseline from its last
child, even if the last child didn't have any line boxes inside.

This caused baselines to slip further down vertically than expected.

There are more baseline alignment issues to fix, but this one was
responsible for a fair chunk of trouble. :^)
This commit is contained in:
Andreas Kling 2023-07-25 10:58:11 +02:00
parent 7b3902e3d5
commit ccf35a973f
7 changed files with 107 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Tests/LibWeb/Layout/expected/block-and-inline/inline-block-baseline-2.txt Normal file
View file

@ -0,0 +1,26 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x600 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x60.40625 children: inline
line 0 width: 144.375, height: 60.40625, bottom: 60.40625, baseline: 35
frag 0 from TextNode start: 0, length: 13, rect: [10,31.46875 103.140625x17.46875]
"Hello friends"
frag 1 from BlockContainer start: 0, length: 0, rect: [114.140625,11 39.234375x58.40625]
TextNode <#text>
BlockContainer <div.ib> at (114.140625,11) content-size 39.234375x58.40625 inline-block [BFC] children: not-inline
BlockContainer <div> at (115.140625,12) content-size 37.234375x17.46875 children: inline
line 0 width: 22.546875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [115.140625,12 22.546875x17.46875]
"1st"
TextNode <#text>
BlockContainer <div> at (115.140625,31.46875) content-size 37.234375x17.46875 children: inline
line 0 width: 26.28125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [115.140625,31.46875 26.28125x17.46875]
"2nd"
TextNode <#text>
BlockContainer <div.float> at (115.140625,50.9375) content-size 37.234375x17.46875 floating [BFC] children: inline
line 0 width: 37.234375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 5, rect: [115.140625,50.9375 37.234375x17.46875]
"float"
TextNode <#text>
BlockContainer <(anonymous)> at (114.140625,49.9375) content-size 39.234375x0 children: inline
TextNode <#text>