RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 19:17:44 +00:00
Code Issues Activity Actions

LibWeb: Derive box baseline from last child *with line boxes*

Browse source 
Before this change, we always derived a box's baseline from its last
child, even if the last child didn't have any line boxes inside.

This caused baselines to slip further down vertically than expected.

There are more baseline alignment issues to fix, but this one was
responsible for a fair chunk of trouble. :^)
This commit is contained in:
Andreas Kling 2023-07-25 10:58:11 +02:00
parent 7b3902e3d5
commit ccf35a973f
7 changed files with 107 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Tests/LibWeb/Layout/expected/block-and-inline/margin-collapse-5.txt
View file

@ -1,12 +1,12 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x135 [BFC] children: inline
line 0 width: 170.96875, height: 135, bottom: 135, baseline: 13.53125
frag 0 from BlockContainer start: 0, length: 0, rect: [2,15.53125 168.96875x119.46875]
BlockContainer <body> at (2,15.53125) content-size 168.96875x119.46875 inline-block [BFC] children: not-inline
BlockContainer <div.hmm> at (3,16.53125) content-size 166.96875x17.46875 children: inline
BlockContainer <html> at (1,1) content-size 798x121.46875 [BFC] children: inline
line 0 width: 170.96875, height: 121.46875, bottom: 121.46875, baseline: 15.53125
frag 0 from BlockContainer start: 0, length: 0, rect: [2,2 168.96875x119.46875]
BlockContainer <body> at (2,2) content-size 168.96875x119.46875 inline-block [BFC] children: not-inline
BlockContainer <div.hmm> at (3,3) content-size 166.96875x17.46875 children: inline
line 0 width: 166.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 21, rect: [3,16.53125 166.96875x17.46875]
frag 0 from TextNode start: 0, length: 21, rect: [3,3 166.96875x17.46875]
"suspiciously tall box"
TextNode <#text>
BlockContainer <(anonymous)> at (2,135) content-size 168.96875x0 children: inline
BlockContainer <(anonymous)> at (2,121.46875) content-size 168.96875x0 children: inline
TextNode <#text>