RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:37:35 +00:00
Code Issues Activity Actions

LibWeb: Derive box baseline from last child *with line boxes*

Browse source 
Before this change, we always derived a box's baseline from its last
child, even if the last child didn't have any line boxes inside.

This caused baselines to slip further down vertically than expected.

There are more baseline alignment issues to fix, but this one was
responsible for a fair chunk of trouble. :^)
This commit is contained in:
Andreas Kling 2023-07-25 10:58:11 +02:00
parent 7b3902e3d5
commit ccf35a973f
7 changed files with 107 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Tests/LibWeb/Layout/input/block-and-inline/inline-block-baseline-1.html Normal file
View file

@ -0,0 +1,16 @@
<style>
* {
border: 1px solid black;
}
.ib {
display: inline-block;
}
.ib div {
background: pink;
}
.ib div.whee {
width: 200px;
height: 50px;
background: orange;
}
</style><body>Hello friends<div class=ib><div>1st</div><div>2nd</div><div class="whee"></div>

15
Tests/LibWeb/Layout/input/block-and-inline/inline-block-baseline-2.html Normal file
View file

@ -0,0 +1,15 @@
<style>
* {
border: 1px solid black;
}
.ib {
display: inline-block;
}
.ib div {
background: pink;
}
.ib div.float {
background: orange;
float: left;
}
</style><body>Hello friends<div class=ib><div>1st</div><div>2nd</div><div class="float">float</div>