RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 17:12:43 +00:00
Code Issues Activity Actions

LibWeb: Move serialization of serializable object's interface name

Browse source 
To be consistent with the deserialization steps, move serialization of
the serializable object's interface name out of the serialization steps.
This commit is contained in:
Kenneth Myhra 2024-03-02 22:32:50 +01:00 • committed by Andrew Kaster
parent 4751ab9f0b
commit cd0302426f
3 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/FileAPI/Blob.cpp
View file

@ -153,8 +153,6 @@ WebIDL::ExceptionOr<void> Blob::serialization_steps(HTML::SerializationRecord& r
{ {
auto& vm = this->vm(); auto& vm = this->vm();
TRY(HTML::serialize_string(vm, record, interface_name()));
// FIXME: 1. Set serialized.[[SnapshotState]] to value’s snapshot state. // FIXME: 1. Set serialized.[[SnapshotState]] to value’s snapshot state.
// NON-STANDARD: FileAPI spec doesn't specify that type should be serialized, although // NON-STANDARD: FileAPI spec doesn't specify that type should be serialized, although

2
Userland/Libraries/LibWeb/FileAPI/File.cpp
View file

@ -91,8 +91,6 @@ WebIDL::ExceptionOr<void> File::serialization_steps(HTML::SerializationRecord& r
{ {
auto& vm = this->vm(); auto& vm = this->vm();
TRY(HTML::serialize_string(vm, record, interface_name()));
// FIXME: 1. Set serialized.[[SnapshotState]] to value’s snapshot state. // FIXME: 1. Set serialized.[[SnapshotState]] to value’s snapshot state.
// NON-STANDARD: FileAPI spec doesn't specify that type should be serialized, although // NON-STANDARD: FileAPI spec doesn't specify that type should be serialized, although

2
Userland/Libraries/LibWeb/HTML/StructuredSerialize.cpp
View file

@ -306,6 +306,8 @@ public:
m_serialized.append(ValueTag::SerializableObject); m_serialized.append(ValueTag::SerializableObject);
TRY(serialize_string(m_vm, m_serialized, serializable.interface_name()));
// 1. Perform the serialization steps for value's primary interface, given value, serialized, and forStorage. // 1. Perform the serialization steps for value's primary interface, given value, serialized, and forStorage.
TRY(serializable.serialization_steps(m_serialized, m_for_storage)); TRY(serializable.serialization_steps(m_serialized, m_for_storage));
} }