RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:48:10 +00:00
Code Issues Activity Actions

Kernel/HID: Take a spinlock when calling KeyboardClient::on_key_pressed

Browse source 
The KeyboardClient class member could be updated due to TTY switch, so
we must ensure we always use a valid pointer.
This commit is contained in:
Liav A 2022-05-06 14:49:13 +03:00 • committed by Linus Groh
parent b8493bf70f
commit cd08c4a5aa
3 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Devices/HID/KeyboardDevice.cpp
View file

@ -254,8 +254,12 @@ void KeyboardDevice::key_state_changed(u8 scan_code, bool pressed)
if (pressed)
event.flags |= Is_Press;
if (HIDManagement::the().m_client)
HIDManagement::the().m_client->on_key_pressed(event);
{
SpinlockLocker locker(HIDManagement::the().m_client_lock);
if (HIDManagement::the().m_client)
HIDManagement::the().m_client->on_key_pressed(event);
}
{
SpinlockLocker lock(m_queue_lock);