RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:27:44 +00:00
Code Issues Activity Actions

LibCore+Everywhere: Return ErrorOr from ConfigFile::sync()

Browse source 
Currently this method always succeeds, but that won't be true once we
switch to the Core::Stream API. :^)

Some of these places would ideally show an error message to the user,
since failure to save a file is significant, but let's not get
distracted right now.
This commit is contained in:
Sam Atkins 2022-02-06 14:26:33 +00:00 • committed by Tim Flynn
parent b90dc408bd
commit cd0ffe5460
10 changed files with 39 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Applications/ThemeEditor/main.cpp
View file

@ -374,7 +374,10 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
theme->write_entry("Paths", to_string(role), preview_widget.preview_palette().path(role));
}
theme->sync();
if (auto sync_result = theme->sync(); sync_result.is_error()) {
// FIXME: Expose this to the user, since failing to save is important to know about!
dbgln("Failed to save theme file: {}", sync_result.error());
}
};
TRY(file_menu->try_add_action(GUI::CommonActions::make_open_action([&](auto&) {