RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 21:48:11 +00:00
Code Issues Activity Actions

LibCore+Everywhere: Return ErrorOr from ConfigFile::sync()

Browse source 
Currently this method always succeeds, but that won't be true once we
switch to the Core::Stream API. :^)

Some of these places would ideally show an error message to the user,
since failure to save a file is significant, but let's not get
distracted right now.
This commit is contained in:
Sam Atkins 2022-02-06 14:26:33 +00:00 • committed by Tim Flynn
parent b90dc408bd
commit cd0ffe5460
10 changed files with 39 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibCore/ConfigFile.cpp
View file

@ -61,7 +61,7 @@ ConfigFile::ConfigFile(String const&, NonnullRefPtr<File> open_file)
ConfigFile::~ConfigFile()
{
sync();
MUST(sync());
}
void ConfigFile::reparse()
@ -168,10 +168,10 @@ void ConfigFile::write_color_entry(String const& group, String const& key, Color
write_entry(group, key, String::formatted("{},{},{},{}", value.red(), value.green(), value.blue(), value.alpha()));
}
bool ConfigFile::sync()
ErrorOr<void> ConfigFile::sync()
{
if (!m_dirty)
return true;
return {};
m_file->truncate(0);
m_file->seek(0);
@ -184,7 +184,7 @@ bool ConfigFile::sync()
}
m_dirty = false;
return true;
return {};
}
void ConfigFile::dump() const