From cd156bad6b942a727fd09283b50c0e37131addb1 Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Thu, 4 Jan 2024 12:36:11 +1300 Subject: [PATCH] LibWeb: Create XMLDocuments in DOMImplementation.createDocument --- .../expected/DOM/DOMImplementation-create-xml-document.txt | 1 + .../input/DOM/DOMImplementation-create-xml-document.html | 7 +++++++ Userland/Libraries/LibWeb/DOM/DOMImplementation.cpp | 6 +++--- 3 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 Tests/LibWeb/Text/expected/DOM/DOMImplementation-create-xml-document.txt create mode 100644 Tests/LibWeb/Text/input/DOM/DOMImplementation-create-xml-document.html diff --git a/Tests/LibWeb/Text/expected/DOM/DOMImplementation-create-xml-document.txt b/Tests/LibWeb/Text/expected/DOM/DOMImplementation-create-xml-document.txt new file mode 100644 index 0000000000..7b4c1cfe76 --- /dev/null +++ b/Tests/LibWeb/Text/expected/DOM/DOMImplementation-create-xml-document.txt @@ -0,0 +1 @@ +XMLDocument diff --git a/Tests/LibWeb/Text/input/DOM/DOMImplementation-create-xml-document.html b/Tests/LibWeb/Text/input/DOM/DOMImplementation-create-xml-document.html new file mode 100644 index 0000000000..db1bbf52cd --- /dev/null +++ b/Tests/LibWeb/Text/input/DOM/DOMImplementation-create-xml-document.html @@ -0,0 +1,7 @@ + + diff --git a/Userland/Libraries/LibWeb/DOM/DOMImplementation.cpp b/Userland/Libraries/LibWeb/DOM/DOMImplementation.cpp index d5a0445db4..b5bca1fe04 100644 --- a/Userland/Libraries/LibWeb/DOM/DOMImplementation.cpp +++ b/Userland/Libraries/LibWeb/DOM/DOMImplementation.cpp @@ -8,10 +8,10 @@ #include #include #include -#include #include #include #include +#include #include #include @@ -48,8 +48,8 @@ void DOMImplementation::visit_edges(Cell::Visitor& visitor) // https://dom.spec.whatwg.org/#dom-domimplementation-createdocument WebIDL::ExceptionOr> DOMImplementation::create_document(Optional const& namespace_, String const& qualified_name, JS::GCPtr doctype) const { - // FIXME: 1. Let document be a new XMLDocument - auto xml_document = Document::create(realm()); + // 1. Let document be a new XMLDocument + auto xml_document = XMLDocument::create(realm()); xml_document->set_ready_for_post_load_tasks(true);