RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 15:42:44 +00:00
Code Issues Activity Actions

SystemMonitor: Split up kmalloc labels

Browse source 
Otherwise, the numbers overflow the space after a while.
This commit is contained in:
Ben Wiederhake 2020-08-02 16:35:49 +02:00 • committed by Andreas Kling
parent cb167ea388
commit cd39eea7a9
2 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Applications/SystemMonitor/MemoryStatsWidget.cpp
View file

@ -50,7 +50,7 @@ MemoryStatsWidget::MemoryStatsWidget(GraphWidget& graph)
s_the = this; s_the = this;
set_size_policy(GUI::SizePolicy::Fill, GUI::SizePolicy::Fixed); set_size_policy(GUI::SizePolicy::Fill, GUI::SizePolicy::Fixed);
set_preferred_size(0, 72); set_preferred_size(0, 110);
set_layout<GUI::VerticalBoxLayout>(); set_layout<GUI::VerticalBoxLayout>();
layout()->set_margins({ 0, 8, 0, 0 }); layout()->set_margins({ 0, 8, 0, 0 });
@ -71,8 +71,10 @@ MemoryStatsWidget::MemoryStatsWidget(GraphWidget& graph)
m_user_physical_pages_label = build_widgets_for_label("Userspace physical:"); m_user_physical_pages_label = build_widgets_for_label("Userspace physical:");
m_supervisor_physical_pages_label = build_widgets_for_label("Supervisor physical:"); m_supervisor_physical_pages_label = build_widgets_for_label("Supervisor physical:");
m_kmalloc_label = build_widgets_for_label("Kernel heap:"); m_kmalloc_space_label = build_widgets_for_label("Kernel heap:");
m_kmalloc_count_label = build_widgets_for_label("Calls kmalloc/kfree:"); m_kmalloc_count_label = build_widgets_for_label("Calls kmalloc:");
m_kfree_count_label = build_widgets_for_label("Calls kfree:");
m_kmalloc_difference_label = build_widgets_for_label("Difference:");
refresh(); refresh();
} }
@ -117,10 +119,12 @@ void MemoryStatsWidget::refresh()
size_t user_pages_available = user_physical_allocated + user_physical_available; size_t user_pages_available = user_physical_allocated + user_physical_available;
size_t supervisor_pages_available = super_physical_alloc + super_physical_free; size_t supervisor_pages_available = super_physical_alloc + super_physical_free;
m_kmalloc_label->set_text(String::format("%uK/%uK", bytes_to_kb(kmalloc_allocated), bytes_to_kb(kmalloc_sum_available))); m_kmalloc_space_label->set_text(String::format("%uK/%uK", bytes_to_kb(kmalloc_allocated), bytes_to_kb(kmalloc_sum_available)));
m_user_physical_pages_label->set_text(String::format("%uK/%uK", page_count_to_kb(user_physical_allocated), page_count_to_kb(user_pages_available))); m_user_physical_pages_label->set_text(String::format("%uK/%uK", page_count_to_kb(user_physical_allocated), page_count_to_kb(user_pages_available)));
m_supervisor_physical_pages_label->set_text(String::format("%uK/%uK", page_count_to_kb(super_physical_alloc), page_count_to_kb(supervisor_pages_available))); m_supervisor_physical_pages_label->set_text(String::format("%uK/%uK", page_count_to_kb(super_physical_alloc), page_count_to_kb(supervisor_pages_available)));
m_kmalloc_count_label->set_text(String::format("%u/%u (+%u)", kmalloc_call_count, kfree_call_count, kmalloc_call_count - kfree_call_count)); m_kmalloc_count_label->set_text(String::format("%u", kmalloc_call_count));
m_kfree_count_label->set_text(String::format("%u", kfree_call_count));
m_kmalloc_difference_label->set_text(String::format("+%u", kmalloc_call_count - kfree_call_count));
m_graph.set_max(page_count_to_kb(user_pages_available)); m_graph.set_max(page_count_to_kb(user_pages_available));
m_graph.add_value(page_count_to_kb(user_physical_allocated)); m_graph.add_value(page_count_to_kb(user_physical_allocated));

4
Applications/SystemMonitor/MemoryStatsWidget.h
View file

@ -45,6 +45,8 @@ private:
GraphWidget& m_graph; GraphWidget& m_graph;
RefPtr<GUI::Label> m_user_physical_pages_label; RefPtr<GUI::Label> m_user_physical_pages_label;
RefPtr<GUI::Label> m_supervisor_physical_pages_label; RefPtr<GUI::Label> m_supervisor_physical_pages_label;
RefPtr<GUI::Label> m_kmalloc_label; RefPtr<GUI::Label> m_kmalloc_space_label;
RefPtr<GUI::Label> m_kmalloc_count_label; RefPtr<GUI::Label> m_kmalloc_count_label;
RefPtr<GUI::Label> m_kfree_count_label;
RefPtr<GUI::Label> m_kmalloc_difference_label;
}; };