RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:17:35 +00:00
Code Issues Activity Actions

FontEditor: Remove listener client

Browse source 
FontEditor was relying on a hack to get notified about i32 config
changes, and scale is not a setting we want updated across all
editor instances, nor do we have any settings that make sense to
monitor universally, so let's remove listener privileges for now.
This commit is contained in:
thankyouverycool 2022-02-16 10:15:19 -05:00 • committed by Tim Flynn
parent 0d29419ed4
commit cd4c11ebaf
3 changed files with 1 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Applications/FontEditor/FontEditor.cpp
View file

@ -803,18 +803,6 @@ void FontEditorWidget::did_resize_glyph_editor()
m_left_column_container->set_fixed_width(max(m_glyph_editor_widget->preferred_width(), glyph_toolbars_width)); m_left_column_container->set_fixed_width(max(m_glyph_editor_widget->preferred_width(), glyph_toolbars_width));
} }
void FontEditorWidget::config_i32_did_change(String const& domain, String const& group, String const& key, i32 value)
{
if (domain == "FontEditor"sv && group == "GlyphEditor"sv && key == "Scale"sv) {
set_scale(value);
}
}
void FontEditorWidget::config_string_did_change(String const& domain, String const& group, String const& key, String const& value)
{
config_i32_did_change(domain, group, key, value.to_int().value_or(10));
}
void FontEditorWidget::set_scale(i32 scale) void FontEditorWidget::set_scale(i32 scale)
{ {
m_glyph_editor_widget->set_scale(scale); m_glyph_editor_widget->set_scale(scale);

7
Userland/Applications/FontEditor/FontEditor.h
View file

@ -8,7 +8,6 @@
#pragma once #pragma once
#include "UndoGlyph.h" #include "UndoGlyph.h"
#include <LibConfig/Listener.h>
#include <LibGUI/ActionGroup.h> #include <LibGUI/ActionGroup.h>
#include <LibGUI/FilteringProxyModel.h> #include <LibGUI/FilteringProxyModel.h>
#include <LibGUI/GlyphMapWidget.h> #include <LibGUI/GlyphMapWidget.h>
@ -19,8 +18,7 @@
class GlyphEditorWidget; class GlyphEditorWidget;
class FontEditorWidget final class FontEditorWidget final
: public GUI::Widget : public GUI::Widget {
, public Config::Listener {
C_OBJECT(FontEditorWidget) C_OBJECT(FontEditorWidget)
public: public:
virtual ~FontEditorWidget() override = default; virtual ~FontEditorWidget() override = default;
@ -48,9 +46,6 @@ private:
virtual void drop_event(GUI::DropEvent&) override; virtual void drop_event(GUI::DropEvent&) override;
virtual void config_i32_did_change(String const& domain, String const& group, String const& key, i32 value) override;
virtual void config_string_did_change(String const& domain, String const& group, String const& key, String const& value) override;
void undo(); void undo();
void redo(); void redo();
void did_modify_font(); void did_modify_font();

1
Userland/Applications/FontEditor/main.cpp
View file

@ -29,7 +29,6 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
TRY(Desktop::Launcher::seal_allowlist()); TRY(Desktop::Launcher::seal_allowlist());
Config::pledge_domain("FontEditor"); Config::pledge_domain("FontEditor");
Config::monitor_domain("FontEditor");
TRY(Core::System::pledge("stdio recvfd sendfd thread rpath cpath wpath")); TRY(Core::System::pledge("stdio recvfd sendfd thread rpath cpath wpath"));
char const* path = nullptr; char const* path = nullptr;