RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 22:38:12 +00:00
Code Issues Activity Actions

LibSQL: Avoid signed arithmetic in IntegerImpl::compare

Browse source
This commit is contained in:
Mahmoud Mandour 2021-11-08 22:29:36 +02:00 • committed by Andreas Kling
parent a962ee020a
commit cd4dba87fa
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibSQL/Value.cpp
View file

@ -704,10 +704,13 @@ bool IntegerImpl::can_cast(Value const& other_value)
int IntegerImpl::compare(Value const& other) const int IntegerImpl::compare(Value const& other) const
{ {
auto casted = other.to_int(); auto casted = other.to_int();
if (!casted.has_value()) { if (!casted.has_value())
return 1; return 1;
}
return value() - casted.value(); if (value() == casted.value())
return 0;
return value() < casted.value() ? -1 : 1;
} }
u32 IntegerImpl::hash() const u32 IntegerImpl::hash() const